[BI-2744] DeltaBreed:Create exp, create obs level CI#498
Merged
nickpalladino merged 7 commits intodevelopfrom Mar 5, 2026
Merged
[BI-2744] DeltaBreed:Create exp, create obs level CI#498nickpalladino merged 7 commits intodevelopfrom
nickpalladino merged 7 commits intodevelopfrom
Conversation
5 tasks
Collaborator
|
Tested with FB. Endless fetching error has been resolved with this change! |
jloux-brapi
requested changes
Mar 4, 2026
Collaborator
jloux-brapi
left a comment
There was a problem hiding this comment.
Just want some extra info on the level names being logged, suggested changes included.
...ter/services/processors/experiment/create/workflow/steps/CommitPendingImportObjectsStep.java
Outdated
Show resolved
Hide resolved
...ter/services/processors/experiment/create/workflow/steps/CommitPendingImportObjectsStep.java
Outdated
Show resolved
Hide resolved
Co-authored-by: jloux-brapi <jloux.brapi@gmail.com>
Co-authored-by: jloux-brapi <jloux.brapi@gmail.com>
Contributor
Author
Good suggestions, committed! |
jloux-brapi
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2744 - DeltaBreed:Create exp, create obs level
Added logic for experimental import to create observation levels for new exp units.
Added validation to check for more than one exp unit in file and return error if so (previous behavior just took the first row exp unit and silently ignored all other rows).
Note: Testing BI-2791 atop experiments made with these changes revealed a niche case where if an import file was made that forcibly included Exp Units of different casings (ie BaconPancakes and BaconPANCAKES), downloading for a particular environment(s) rather than "All Environments" resulted in the download failing due to a null pointer exception because in BrAPITrialService.java:exportObservations, the hash "entry" would get an additional value with a null key for the alternate casing version of the Exp Unit. Since this logic is dependent upon the Exp Unit value stored in additionalInfo, it was determined that the fix should be covered in BI-2778, which will deprecate use of additionalInfo for level, and that case tested there.
Dependencies
bi-web: feature/BI-2744
Testing
Create experiment file with multiple exp unit values
-- Attempt to upload file
-- Error message should appear and file upload should be prevented
Create experiment file with new exp unit value (not Plot)
-- Upload file
-- Ensure Experiment Preview displays the exp unit value as capitalized regardless of what case the value was in file
-- Confirm Import and ensure file imports successfully
-- Ensure Experiment Details displays the exp unit value as capitalized regardless of what case the value was in file
-- Check that the GET /observationlevels call for that program returns the new exp unit value
Create experiment file with same exp unit value as the first upload
-- Upload file
-- Confirm Import and ensure file imports successfully
Checklist: