Skip to content

Development#26

Merged
Cristianetaniguti merged 28 commits intomainfrom
development
May 6, 2025
Merged

Development#26
Cristianetaniguti merged 28 commits intomainfrom
development

Conversation

@Cristianetaniguti
Copy link
Collaborator

@Cristianetaniguti Cristianetaniguti commented May 5, 2025

  • Integration with codecov
  • Improvements of tests
  • Add function for pedigree relationship check

@Cristianetaniguti Cristianetaniguti added the in_progress not ready to merge label May 5, 2025
@Cristianetaniguti
Copy link
Collaborator Author

Coming next

Fix for this note:

❯ checking dependencies in R code ... NOTE
  Unexported object imported by a ':::' call: ‘vcfR:::.write_vcf_body’
    See the note in ?`:::` about the use of this operator.

}

# Assign the result dataframe to the output variable
if (!is.null(output)) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josuechinchilla I had the modify the function here to attend requirements from CRAN. Is it okay? I removed the "output" argument

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might want to keep the title as: "Breeding Insight Genomics Functions for Polypoid and Diploid Species". This is because "Breeding Insight Genomics" is referring to the BI team that developed the package, and not the type of functions that are included which are both genomics and pedigree/phenotype analysis functions

@Cristianetaniguti Cristianetaniguti added enhancement New feature or request and removed in_progress not ready to merge labels May 6, 2025
@Cristianetaniguti Cristianetaniguti merged commit 23005ec into main May 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants