Conversation
alex-sandercock
left a comment
There was a problem hiding this comment.
There were a few additional files that seem to require that the input VCF be compressed. I think it is OK to allow the user to use an uncompressed VCF if that was the intention.
There was a problem hiding this comment.
Is this requiring that the VCF file be compressed for the analysis to run?
There was a problem hiding this comment.
It should be OK to use a compressed or uncompressed file
There was a problem hiding this comment.
Yes, both are allowed, but there was a bug with our example uncompressed VCF because it has less/equal 100 markers, the same/less amount than the subsetting for testing. Bug fixed.
The check will only break if the file has the .gz but it is not compressed or the opposite, or if it has non compatible compression (bz2 or .xz)
There was a problem hiding this comment.
We should not prevent users from trying the analysis with large marker sets, but a warning is useful to let them know if could take a while.
- I assume that the change here would be to add "max_markers" to warning_if_false instead of error_if_false?
There was a problem hiding this comment.
yes, this was the required change... done!
There was a problem hiding this comment.
Is VCF being required to be compressed?
There was a problem hiding this comment.
Nope.. see comment above
Uh oh!
There was an error while loading. Please reload this page.