Skip to content

Vcf sanity check#143

Merged
alex-sandercock merged 27 commits intodevelopmentfrom
vcf_sanity_check
Aug 25, 2025
Merged

Vcf sanity check#143
alex-sandercock merged 27 commits intodevelopmentfrom
vcf_sanity_check

Conversation

@Cristianetaniguti
Copy link
Collaborator

@Cristianetaniguti Cristianetaniguti commented Aug 11, 2025

  • Avoid VCF sanity check function to return errors only in the terminal
  • Add option to export viewpoly HIDECAN input from GWASpoly run
  • Add VCF sanity check to filter tab -- this still has a bug because the VCF reading is inside a ObserveEvent, the user doesn't need to press the button to start the process. If the process takes time, user will press the button and the app may crash if the analysis start without the requirements.
  • New button to export PCA values data as csv
  • Working in progress to create arm64 docker image for BIGapp - amd64 is done

@Cristianetaniguti Cristianetaniguti added the work in progress More commits are coming label Aug 11, 2025
Copy link
Collaborator

@alex-sandercock alex-sandercock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a few additional files that seem to require that the input VCF be compressed. I think it is OK to allow the user to use an uncompressed VCF if that was the intention.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this requiring that the VCF file be compressed for the analysis to run?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be OK to use a compressed or uncompressed file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, both are allowed, but there was a bug with our example uncompressed VCF because it has less/equal 100 markers, the same/less amount than the subsetting for testing. Bug fixed.
The check will only break if the file has the .gz but it is not compressed or the opposite, or if it has non compatible compression (bz2 or .xz)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not prevent users from trying the analysis with large marker sets, but a warning is useful to let them know if could take a while.

  • I assume that the change here would be to add "max_markers" to warning_if_false instead of error_if_false?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this was the required change... done!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is VCF being required to be compressed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.. see comment above

Copy link
Collaborator

@alex-sandercock alex-sandercock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alex-sandercock alex-sandercock merged commit 91f9b9a into development Aug 25, 2025
4 checks passed
@alex-sandercock alex-sandercock deleted the vcf_sanity_check branch August 25, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Waiting feedback work in progress More commits are coming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants