Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quoting around data_sync_id and visitor_data #49

Closed
wants to merge 1 commit into from

Conversation

Brainicism
Copy link
Owner

No description provided.

@Brainicism Brainicism requested a review from grqz January 28, 2025 02:08
Copy link

@ryneeverett ryneeverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the intent is but I'd be surprised if this fixed anything. Per the subprocess docs:

Providing a sequence of arguments is generally preferred, as it allows the module to take care of any required escaping and quoting of arguments (e.g. to permit spaces in file names).

My reading is that without shell=True there should be no possibility of word splitting or interpolation here.

@Brainicism
Copy link
Owner Author

Not sure what the intent is but I'd be surprised if this fixed anything. Per the subprocess docs:

Providing a sequence of arguments is generally preferred, as it allows the module to take care of any required escaping and quoting of arguments (e.g. to permit spaces in file names).

My reading is that without shell=True there should be no possibility of word splitting or interpolation here.

Good catch! I assumed that there was interpolation here because of #47 (comment), where it looks like the data_sync_id is being split at the |. Regardless of if it fixes anything, its probably better to quote these anyway for convention anyway

@ryneeverett
Copy link

IMO it's pretty unconventional to quote arguments passed to subprocess because, as the docs say, subprocess takes care of it. I have to believe that it's highly unlikely you've encountered a bug in such a widely used module so I'd suggest exploring more probable root causes.

While I admit that is odd looking I wonder if the pipes are an oddity of the OP's terminal emulator truncating a long line. (Are pipes even valid characters in a data_sync_id?) Regardless I think you're on a better track exploring the OP's node environment because that javascript SyntaxError does seem like the real root cause.

@Brainicism Brainicism closed this Jan 28, 2025
@grqz grqz deleted the quote-ids branch January 29, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants