hide proxy password in server log (#50)

* hide proxy password in server log * fixup! hide proxy password in server log * fixup! fixup! hide proxy password in server log * fixup! fixup! fixup! hide proxy password in server log * fixup! fixup! fixup! fixup! hide proxy password in server log * fixup! fixup! fixup! fixup! fixup! hide proxy password in server log
Brainicism · Feb 12, 2025 · ffcb42d · ffcb42d
1 parent c98155c
commit ffcb42d
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/server/src/session_manager.ts b/server/src/session_manager.ts
@@ -110,20 +110,31 @@ export class SessionManager {
             proxy = `http://${proxy}`;
         }
 
+        let loggedProxy: string = proxy;
+        try {
+            const parsedUrl = new URL(proxy);
+            if (parsedUrl.password) {
+                loggedProxy = proxy.replace(parsedUrl.password, "****");
+            }
+        } catch (e) {
+            this.logger.warn(`Fail to parse proxy url ${proxy}: ${e}`);
+            return undefined;
+        }
+
         switch (protocol) {
             case "http":
             case "https":
-                this.logger.log(`Using HTTP/HTTPS proxy: ${proxy}`);
+                this.logger.log(`Using HTTP/HTTPS proxy: ${loggedProxy}`);
                 return new HttpsProxyAgent(proxy);
             case "socks":
             case "socks4":
             case "socks4a":
             case "socks5":
             case "socks5h":
-                this.logger.log(`Using SOCKS proxy: ${proxy}`);
+                this.logger.log(`Using SOCKS proxy: ${loggedProxy}`);
                 return new SocksProxyAgent(proxy);
             default:
-                this.logger.warn(`Unsupported proxy protocol: ${proxy}`);
+                this.logger.warn(`Unsupported proxy protocol: ${loggedProxy}`);
                 return undefined;
         }
     }