Skip to content

[REFACT] 조회 쿼리 성능 개선 및 코드 수정 (#239) #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kfdsy0103 merged 2 commits into from
Feb 20, 2025
Merged

[REFACT] 조회 쿼리 성능 개선 및 코드 수정 (#239) #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e6b00f
[REFACT] @BatchSize로 중복 쿼리 제거
kfdsy0103 Feb 20, 2025
a339850
[FIX] orderId 누락 수정
kfdsy0103 Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/brainpix/joining/entity/quantity/Price.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package com.brainpix.joining.entity.quantity;

import org.hibernate.annotations.BatchSize;

import jakarta.persistence.Entity;
import jakarta.persistence.EnumType;
import jakarta.persistence.Enumerated;
Expand All @@ -10,6 +12,7 @@
import lombok.Getter;
import lombok.NoArgsConstructor;

@BatchSize(size = 10)
@Entity
@NoArgsConstructor
@Getter
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/brainpix/kakaopay/converter/KakaoPayReadyDtoConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public static KakaoPayReadyDto.Response toResponse(KakaoPayReadyDto.KakaoApiResp

return KakaoPayReadyDto.Response.builder()
.nextRedirectPcUrl(kakaoApiResponse.getNext_redirect_pc_url())
.orderId(orderId)
.build();
}

Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/brainpix/kakaopay/dto/KakaoPayReadyDto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,6 @@ public static class KakaoApiResponse {
@Builder
public static class Response {
private String nextRedirectPcUrl;
private String orderId;
}
}
3 changes: 3 additions & 0 deletions src/main/java/com/brainpix/post/entity/Post.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import java.util.List;

import org.hibernate.annotations.BatchSize;

import com.brainpix.api.code.error.PostErrorCode;
import com.brainpix.api.exception.BrainPixException;
import com.brainpix.jpa.BaseTimeEntity;
Expand Down Expand Up @@ -47,6 +49,7 @@ public abstract class Post extends BaseTimeEntity {
@Enumerated(EnumType.STRING)
private Specialization specialization;

@BatchSize(size = 10)
@ElementCollection
private List<String> imageList;

Expand Down
6 changes: 4 additions & 2 deletions src/main/java/com/brainpix/user/entity/User.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import java.time.LocalDate;

import org.hibernate.annotations.BatchSize;

import com.brainpix.jpa.BaseTimeEntity;
import com.brainpix.profile.entity.Profile;
import com.brainpix.security.authority.BrainpixAuthority;
Expand All @@ -18,6 +20,7 @@
import lombok.Getter;
import lombok.NoArgsConstructor;

@BatchSize(size = 10)
@Entity
@Table(name = "users") //user 테이블 이름과 SQL 예약어 충돌 (테스트할때 충돌나서 넣었습니다)
@Inheritance(strategy = InheritanceType.JOINED)
Expand Down Expand Up @@ -57,11 +60,10 @@ public long getProfileId() {
return profile.getId();
}


public abstract String getUserType();

public abstract BrainpixAuthority getAuthority();

public void updateProfileImage(String profileImage) {
this.profileImage = profileImage;
}
Expand Down