Repository navigation
Giv 404-siden en dansk stack med humor - #163
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ukendte adresser får en selvstændig, centreret 404-side med overskriften “404: Der mangler noget i stacken.” og en illustration baseret på sitets logo med Dannebrog og en manglende brik. Besøgende kan finde produktlisten, gå til forsiden via dansktechstack.dk eller afspille en lille genstart-animation.
Siden har ingen header, footer eller citater. Layoutet tilpasser sig mobil og desktop samt sitets mørke tema. HTTP 404 og
noindex, followbevares. Indhold og navigation virker uden JavaScript, hvor genstart-knappen er skjult.Under review blev to tilgængelighedsproblemer rettet: Tastaturfokus bevares efter en genstart, og den automatiske svæveanimation stopper efter fem sekunder.
prefers-reduced-motionslår animationerne fra.Validering:
php tools/check-alternative-pages.php: alle 431 alternativsider samt 404-tjek består.node --check assets/404.jsoggit diff --checkbestår.origin/main.Begrænsning: WebKit kunne ikke testes, fordi den installerede lokale macOS-browser hænger ved oprettelse af en ny fane, også i et separat minimalt forsøg.