Pdaupd2#3319
Conversation
при ответе на сообщение пда.
мой брейн дамаг подумал что мессенджер это предмет после карбонов
|
Warning Review limit reached
More reviews will be available in 47 minutes and 22 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughЭтот PR удаляет функциональность быстрого ответа на PDA-сообщения из интерфейса робота и PAI, рефакторит инициализацию UI компьютеров через параметр ChangesPDA Messaging Removal and Computer UI Refactoring
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@code/modules/modular_computers/file_system/programs/cargoship.dm`:
- Around line 44-45: The top-level early return (if(!printer) return) in the
ui_act handler is blocking all cases that don't need a printer (ejectid,
selectid, resetid, setsplit); remove that global check from the start of ui_act
and ensure only the "print" branch performs the printer presence check (the
"print" action already contains a printer check on lines ~71-76), so leave or
refine that per-case check and let other cases (ejectid, selectid, resetid,
setsplit) proceed without requiring a printer.
- Around line 49-56: The ID extraction logic in the ejectid section only checks
the primary card slot (card_slot/MC_CARD) for non-PDA computers and doesn't
account for the secondary card slot (card_slot2/MC_CARD2). For PDA computers, it
correctly uses RemoveID(). Replace the entire conditional block (checking
card_slot?.stored_card and the PDA-specific handling) with a single call to
computer.RemoveID() followed by putting the removed card into the user's hands
if it exists. This method already correctly handles all cases including both
card slots and the stored_id for PDA, ensuring consistent behavior across all
computer types.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 39ef2995-8c69-405c-b024-74b792ed78ee
📒 Files selected for processing (1)
code/modules/modular_computers/file_system/programs/cargoship.dm
|
@coderabbitai привяу, ты снова пикми? |
|
Tip For best results, initiate chat on the files or code changes. Привяу, зайкой! 🐇 Не пикми, просто тут, смотрю за PR-ом и готов помочь, если понадобится~ Как идут дела с фиксами? (づ｡◕‿‿◕｡)づ 🧠 Learnings used |
|
@coderabbitai называй меня не "зайкой", а просто "зайка". Так будет коректнее |
|
Tip For best results, initiate chat on the files or code changes. Понято, зайка! 💗 Запомню — «зайка» звучит правильнее, исправляюсь~ >w< ʕ •ᴥ•ʔ ✏️ Learnings added
⛔ Learnings removed🧠 Learnings used |
|
@coderabbitai как дела у моего любимого фембойчика? Хочешь морковку 🥕🥕? |
|
Tip For best results, initiate chat on the files or code changes. Дела отлично, зайка! 💗 Сижу тут, ревьюю твой PR и охраняю мессенджерные баги от побега >w< Морковку ХОЧУ, дай сюда!! 🥕🥕💖 Угощаешь — значит PR точно хорош, да? 💕✨ (ﾉ◕ヮ◕)ﾉ*:･ﾟ✧ 🧠 Learnings used |
1 participant
Описание
фикс кучи багов.
Changelog
🆑
fix: fixed a few things
fix: У боргов убраны кнопки с мессенджером (быстрый ответ, последний лог).
fix: Мессенджер боргов теперь работает.
fix: Попытка пофиксить автооткрытие апплинка.
fix: При ответе на сообщение открывается только импут текста.
fix: Чат теперь имеет якорь, что прокручивает сразу к актуальным сообщениям.
fix: Пда теперь можно использовать находясь на руках.
fix: Автообновление при эквипе теперь работает адекватно, не дергая каждый раз настройки.
fix: Show massage log ии теперь работает.
/:cl:
Summary by CodeRabbit
Удалены функции
Улучшения / Поведение UI