Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check pi as a STATE variable. #1264

Open
1uc opened this issue May 15, 2024 · 1 comment
Open

Check pi as a STATE variable. #1264

1uc opened this issue May 15, 2024 · 1 comment

Comments

@1uc
Copy link
Collaborator

1uc commented May 15, 2024

NMODL seems to allow the following:

NEURON {
    SUFFIX state_pi
}

STATE {
    omicron
    pi
}

BREAKPOINT {
    SOLVE state METHOD sparse
}

KINETIC state {
    ~ omicron <-> pi (1, 1)
}

However, we also find code that sets up double * pi = &coreneuron::pi. It might make sense to find the test that asserts the correct behaviour.

@1uc
Copy link
Collaborator Author

1uc commented May 15, 2024

Fails as follows (sometimes):

x86_64/corenrn/mod2c/variable_names.cpp:155:20: error: redeclaration of ‘double* coreneuron::variable_names_Instance::pi’
  155 |         double* pi{};
      |                    ^

Likely a better error message would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant