Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review inst->{point_process,tq_item}. #1236

Open
1uc opened this issue Apr 10, 2024 · 0 comments
Open

Review inst->{point_process,tq_item}. #1236

1uc opened this issue Apr 10, 2024 · 0 comments

Comments

@1uc
Copy link
Collaborator

1uc commented Apr 10, 2024

For CoreNEURON we generate:

    static inline void setup_instance(NrnThread* nt, Memb_list* ml) {
        // ...
        inst->tsave = ml->data+2*pnodecount;
        // ...
        inst->point_process = ml->pdata;
        inst->tqitem = ml->pdata;

and then later inst->tqitem[2*pnodecount+id] and inst->tsave[id].

Meaning often a pointer that's given a name, i.e. tsave or any other range variables, points to the start of it's values. Where as others, such as ml->tqitem don't they point to the beginning of the buffer holding all pdata.

We should review if this a inconsistency that can be unified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant