Ignore unknown decode options in Whisper generate - #873
Merged
lucasnewman merged 1 commit intoAug 5, 2026
Merged
Conversation
Whisper's generate() takes **decode_options and splats them straight into DecodingOptions, so any caller-supplied kwarg the dataclass does not declare raises TypeError. Every other STT model in the tree tolerates extra kwargs, which makes Whisper the odd one out for generic callers that pass a shared set of generation parameters. The existing code already worked around this by popping max_tokens and generation_stream by hand, an allowlist maintained as a blacklist. Derive the accepted names from fields(DecodingOptions) instead so the filter cannot drift from the dataclass. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Collaborator
Author
|
closed the other one! |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whisper's generate() takes **decode_options and splats them straight into DecodingOptions, so any caller-supplied kwarg the dataclass does not declare raises TypeError. Every other STT model in the tree tolerates extra kwargs, which makes Whisper the odd one out for generic callers that pass a shared set of generation parameters.
The existing code already worked around this by popping max_tokens and generation_stream by hand, an allowlist maintained as a blacklist. Derive the accepted names from fields(DecodingOptions) instead so the filter cannot drift from the dataclass.