Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another portion of the formatting and import fixes #1789

Merged
merged 4 commits into from
Jul 28, 2021
Merged

Another portion of the formatting and import fixes #1789

merged 4 commits into from
Jul 28, 2021

Conversation

g1itch
Copy link
Collaborator

@g1itch g1itch commented Jul 21, 2021

This changeset removes more weird imports, adds more six and addresses some minor lint warnings.

@g1itch g1itch added the formatting Code or UI text formatting label Jul 21, 2021
@g1itch
Copy link
Collaborator Author

g1itch commented Jul 26, 2021 •
edited
Loading

Note how most of the compatibility tests pass with this changeset with no need for dirty pasta from #1786:
https://github.com/g1itch/PyBitmessage/runs/3165668219

Only protocol.checkSocksIP() is left: https://github.com/g1itch/PyBitmessage/runs/3166340157

@g1itch g1itch requested a review from PeterSurda July 26, 2021 20:45
PeterSurda
PeterSurda approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@PeterSurda PeterSurda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@g1itch g1itch merged commit f9c49fb into Bitmessage:v0.6 Jul 28, 2021
@g1itch g1itch mentioned this pull request Jul 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterSurda PeterSurda PeterSurda approved these changes

Assignees
No one assigned
Labels
formatting Code or UI text formatting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g1itch @PeterSurda