-
Notifications
You must be signed in to change notification settings - Fork 24
NFT Collection page #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NFT Collection page #624
Conversation
pages/nft-volumes/index.js
Outdated
const { text } = options | ||
|
||
// Create collection ID from issuer:taxon format | ||
if (data.collectionDetails?.issuer) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not always a valid format; collections of sologenic are not identified by issuer and taxon.
we need to make sure sologenic nft collections are linked properly
There is no names for sologenic collections, no links http://localhost:3000/en/nft-volumes?period=all&sale=primaryAndSecondary¤cy=XRP in production we have it: https://bithomp.com/en/nft-volumes?period=all&sale=primaryAndSecondary¤cy=XRP ![]() |
pages/nft-collection/[id].js
Outdated
const [mounted, setMounted] = useState(false) | ||
const [nftList, setNftList] = useState([]) | ||
const [nftListLoading, setNftListLoading] = useState(false) | ||
const { statistics } = data.collection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot retrirve if from data, that is not defined from the initiation.
that also breaks the code, as 'collection' is undefined.
TypeError: Cannot destructure property 'statistics' of 'pageMeta.collection' as it is undefined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks raw
- js erorrs
- hudration errors
- collection links are broken
- need examples where to see collection data with image and metadata
…com/pandablue0809/bithomp-frontend-react into feat/551/update-NFT-collection-page
@ihomp |
Can't open a page, getting js errors: Cannot read properties of undefined (reading 'collection') on line 528 |
All the nft-collections page I open says: no image available, lots of empty space on the left side.. on the top I see some nfts from collections, but there is no link to view all of them |
@Anna15170221 can you test pls and suggest updates |
@pandablue0809 @ihomp
![]() ![]() ![]()
|
Agree with all the points @Anna15170221 ! |
Issue
Create NFT collection page