Skip to content

Conversation

pandablue0809
Copy link
Member

const { text } = options

// Create collection ID from issuer:taxon format
if (data.collectionDetails?.issuer) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not always a valid format; collections of sologenic are not identified by issuer and taxon.

we need to make sure sologenic nft collections are linked properly

@ihomp
Copy link
Member

ihomp commented Sep 25, 2025

const [mounted, setMounted] = useState(false)
const [nftList, setNftList] = useState([])
const [nftListLoading, setNftListLoading] = useState(false)
const { statistics } = data.collection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot retrirve if from data, that is not defined from the initiation.

that also breaks the code, as 'collection' is undefined.

TypeError: Cannot destructure property 'statistics' of 'pageMeta.collection' as it is undefined.

Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks raw

  • js erorrs
  • hudration errors
  • collection links are broken
  • need examples where to see collection data with image and metadata

@pandablue0809
Copy link
Member Author

@ihomp
i fixed it.
if you click the link of name, you can see new page
plz review again. 🙏

@pandablue0809 pandablue0809 requested a review from ihomp September 25, 2025 15:57
@ihomp
Copy link
Member

ihomp commented Sep 28, 2025

Can't open a page, getting js errors:

Cannot read properties of undefined (reading 'collection') on line 528

@ihomp
Copy link
Member

ihomp commented Sep 28, 2025

All the nft-collections page I open says: no image available, lots of empty space on the left side..

on the top I see some nfts from collections, but there is no link to view all of them

@ihomp
Copy link
Member

ihomp commented Sep 28, 2025

@Anna15170221 can you test pls and suggest updates

@Anna15170221
Copy link
Contributor

Anna15170221 commented Sep 30, 2025

@pandablue0809 @ihomp
in addition to Slava's comment above,

  • I think we should mention collection name in the top. For collections where name isn't specified, we should probably mention the same way like we do on this page http://localhost:3000/en/nft-volumes?period=week - write issuer and taxon
  • I think we need to add Collection description and show the stats as well here to make the page more informative. And probably we should show all collection items here, or, yes, at least the link to view them all)(@ihomp do you agree?)
  • if we place some info into hexagonal - it should be readable and not cut when hovering or without.
Screenshot 2025-09-30 at 13 54 00 Screenshot 2025-09-30 at 13 55 51 - I would say "price" instead of "amount" and there is something wrong with the amount digits. And I would show the price in XRP and in fiat. Screenshot 2025-09-30 at 14 02 54
  • If we mention the seller, I would also mention the Buyer in the recent sales.

  • In the recent listings I would also mention the price in XRP and fiat.

@ihomp
Copy link
Member

ihomp commented Sep 30, 2025

Agree with all the points @Anna15170221 !
Please update @pandablue0809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants