-
Notifications
You must be signed in to change notification settings - Fork 25
/account page - DEX orders section - Mobile view #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
/account page - DEX orders section - Mobile view #620
Conversation
|
@ihomp @pandablue0809 |
-> instead of for is good.. Buying means the user wants to buy exactly 37600 xrp - and he agrees to the worse rate of 39.193 for 1 btc, in reality it will be a better rate usually, he will get exactly 37600 xrp but will pay less than 0.96 xrp. when selling - it's exact amount that user sells, doesn't now how much it will it get, but agrees for the minimum amoumt it will get, in reality it will get more than in the offer. |
|
The code looks unoptimized. type of offer.TakerGets === 'string' we shouldn't check if it's a native currency or iou we already have lot's of functions to deal with amounts and formating in the utils. On mobile: Action: Cancel the offer. XRP doesn't need an icon, it can be just text: XRP It's better to form offers like, so it will be understandable that the received/spent amount can be different than in the offer. Selling 10 XRP, wants a minimum of 40 USD |
|
@ihomp |
components/Account/DexOrdersData.js
Outdated
| <span>1 {payCurrency} = </span> | ||
| <span className="no-brake"> | ||
| {typeof offer.TakerGets === 'string' | ||
| ? niceNumber(divide(1, offer.quality * 1000000), 0, null, 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use amountFormat for amount formating for bith native currencies and IOUs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use amountFormat for amount formating for both native currencies and IOUs.
components/Account/DexOrdersData.js
Outdated
| <span>1 {getCurrency} = </span> | ||
| <span className="no-brake"> | ||
| {typeof offer.TakerGets === 'string' | ||
| ? niceNumber(multiply(offer.quality, 1000000), 0, null, 5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use amountFormat for amount formating for bith native currencies and IOUs.
|
we still need to have offer ids on the desktop, right now we have them only on the mobile |
|
@ihomp |


Issue
update the DEX orders section for mobile view