New Page – Account Settings Update #619
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihomp
reviewed
Sep 28, 2025
pages/services/account-settings.js
Outdated
| return { isValid: true, message: '' } // Empty is valid (will be cleared) | ||
| } | ||
|
|
||
| const isHex = /^[0-9a-fA-F]+$/.test(trimmed) |
There was a problem hiding this comment.
please use isHexString from utils
ihomp
reviewed
Sep 28, 2025
pages/services/account-settings.js
Outdated
| return { isValid: true, message: '' } // Empty is valid (will be cleared) | ||
| } | ||
|
|
||
| const isHex = /^[0-9a-fA-F]+$/.test(trimmed) |
ihomp
reviewed
Sep 28, 2025
pages/services/account-settings.js
Outdated
|
|
||
| const handleSetMessageKey = () => { | ||
| const value = messageKeyInput.trim() | ||
| const isHex = /^[0-9a-fA-F]+$/.test(value) |
ihomp
reviewed
Sep 28, 2025
pages/services/account-settings.js
Outdated
| const isValid = /^[0-9a-fA-F]{64}$/.test(value) | ||
| if (!isValid) { | ||
| setErrorMessage('Please enter a valid WalletLocator (64 hexadecimal characters).') | ||
| const isHex = /^[0-9a-fA-F]+$/.test(value) |
ihomp
reviewed
Sep 28, 2025
|
@pandablue0809 the code seems liks unoptimised, some things like seems copy-pasted again.. and we need to reuse the utils function at least for validating hex, we have two functions there already. @Anna15170221 please test if all the things you mentioned now fixed |
|
@ihomp |
|
@Anna15170221 please test if all the things you mentioned are now fixed |
|
@pandablue0809 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
when we enter something not suitable in the message key field, it just doesn't let us proceed - show some error with explanation or example what we are expecting to get there
The same for wallet Locator
tick-size 1-2 doesn't show any errors - user can't see why it can not press the button