Skip to content

Conversation

pandablue0809
Copy link
Member

@pandablue0809 pandablue0809 requested a review from ihomp September 11, 2025 12:00
@ihomp
Copy link
Member

ihomp commented Sep 14, 2025

@Anna15170221 can you please test this one

@Anna15170221
Copy link
Contributor

@ihomp
I think

  1. We need to add explanations on the page: something like: Use these test wallets to try all features of the page. Want to add your address? Sign in here(link).
  2. We need to make this page displayed right away with clicking just 1 link. For example in the services section. Something like Play with a Sample Tax Report or Check How Tax Reports Work or Try Out Tax Reports
  3. seems like load more data button doesn't work - we show 1000 txs for each wallet, if we press the button, these numbers 1-4000 of 5223 are changing but transactions are not loaded

@pandablue0809
Copy link
Member Author

@ihomp
i fixed it. plz review again. 🙏

@ihomp
Copy link
Member

ihomp commented Sep 26, 2025

Screenshot 2025-09-26 at 09 34 21

There seem like lots of troubles.

  • LP tokens don't show the pairs.
  • LP tokens don't always show the value, says NAN
  • the sorting by largest FIAT or largest XRP values seems broken too
  • when changing sorting - loaded transactions are erased, but no notification about it, easy to miss. if not all transactions are loaded - then sorting is invalid - may be we should diasble sorting when not all transactions loaded
  • there are more than a million transactions, I guess 10k would be enough for all the wallets. may be we can remove some wallets

@Anna15170221

In general, we can move all this functionality to a new website right away.

@pandablue0809
Copy link
Member Author

@ihomp
i fixed it. plz review again. 🙏

@ihomp
Copy link
Member

ihomp commented Sep 30, 2025

@Anna15170221 please test and leave your feedback

@Anna15170221
Copy link
Contributor

@pandablue0809 @ihomp

  • do we really need the pop-up message about loaded txs in the top?
  • since we switched off the sorting options when not all the transactions are loaded - we need to put the explanation there (Load all transactions to enable the sorting.) Not clear why it's disabled.
  • when all transactions are loaded and the sorting options are enabled, I choose the sorting by earliest for example and they get disabled again. And I need to load transactions again. It's the same with all the other sorting options
  • i guess something is wrong currently with calculation logic when we load transactions for several wallets simultaniously:
    we show that we loaded 22000 txs of 17995 possible?
Screenshot 2025-10-02 at 12 29 53 but actually we loaded only Screenshot 2025-10-02 at 12 31 35 - the option to filter sometimes works buggy, need to test a bit more, sometimes we show that we loaded txs but don't show them actually - we have the same in the main branch currently - but I assume we need to fix it - when we remove the dust txs we don't change the amount of total transactions we managed to find. - When getting the txs for two or three wallets I often get this - we need to understand what's happening here Screenshot 2025-10-02 at 12 58 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants