Skip to content

Conversation

@pandablue0809
Copy link
Member

@pandablue0809 pandablue0809 requested a review from ihomp September 7, 2025 19:42
<Link href="/services/account-settings/">Account Settings</Link>
<Link href="/services/nft-mint">{t('menu.services.nft-mint')}</Link>
<Link href="/username">{t('menu.usernames')}</Link>
<Link href="/xrp-xah-taxes">{t('menu.services.tax-reports')}</Link>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be in the same PR?

@ihomp
Copy link
Member

ihomp commented Sep 14, 2025

@Anna15170221 can you help testing this one and give your feedback

@Anna15170221
Copy link
Contributor

@ihomp @pandablue0809
my findings

  • let's use the same button style as we have for the whole project
Screenshot 2025-09-15 at 14 46 29
  • Instead of Upgade to Pro let's use the same button Register or Sign in
Screenshot 2025-09-15 at 13 30 03
  • when I log in i got this error
Screenshot 2025-09-15 at 13 33 19
  • not visible text for dark theme
Screenshot 2025-09-15 at 14 39 35
  • I think we need to add short explanations about the fields we offer to fill (rate, tick size and so on)

  • it's not clear what I am supposed to do to continue, the buttons are not active

Screenshot 2025-09-15 at 14 53 25
  • for Xahau network we shouldn't show XRPL we should show Xahau

@pandablue0809
Copy link
Member Author

@ihomp
i fixed it. plz review again. 🙏

@pandablue0809 pandablue0809 requested a review from ihomp September 16, 2025 20:58
@ihomp
Copy link
Member

ihomp commented Sep 28, 2025

@Anna15170221 can you please test again, thx

@Anna15170221
Copy link
Contributor

@pandablue0809 @ihomp

  • The "Configure Cold/HOT Wallet" button is always inactive. Should it be like this?
Screen.Recording.2025-09-30.at.16.14.12.mov
  • if I press back to previous step, it erases some fields on the previous page (the address for example)

  • We have Transfer rate in both Cold and Hot Wallet configurations - should it be like this? we shouldn't mention it in Hot Wallet Configs, I guess. https://xrpl.org/docs/tutorials/how-tos/use-tokens/issue-a-fungible-token. And it can be 0-1%, so the user can't be allowed to enter something different. @ihomp Am i right?

  • I think we are missing the explanation for settings, for tick size and others.

  • If on the previous step we specified that the limit can be 1000, why do we mention that it can be 1000 or higher?

Screenshot 2025-09-30 at 17 20 55
  • Step 3: I think we need to make it possible to create a trustline right away on this page. Otherwise it's a gap in the whole process and the user will need to go somewhere else to create the trustline. And after setting the trustline, the user will send the token from one wallet to another. - He also should have an opportunity to do it right away on this page as the part of the process.
    At this moment Step 3 seems to be not finalised at all and the buttons are inactive.
Screenshot 2025-09-30 at 17 27 59

@pandablue0809
Copy link
Member Author

@Anna15170221 @ihomp
i fixed it.
and if i input the wallet address, the "Configure Cold/Host Wallet" is active.
plz review again. 🙏

@ihomp
Copy link
Member

ihomp commented Oct 10, 2025

@Anna15170221 pls test when you have time

@Anna15170221
Copy link
Contributor

@pandablue0809
I have a question. Did you manage to successfully issue a token using this page?
https://bithomp.com/en/learn/issue-a-token - I would recommend to read this text, it's short and written in simple words, probably this will somehow help you to proceed with the page.

  1. On Step 1 let's add the options to enter: the Token Name, The Token Ticker, The Token Description and upload the image. This will go before setting the supply type.
  2. Transfer rate is % of total supply that will be transferred to hot wallet - that's is not correct, I assume, this is a percentage fee charged on payments made in this token. Change the wording.
  3. If I entered the address the button to config is still disabled, It becomes enabled only if I sign in. We should explain this point to the user otherwise it's not clear. And this should be clear for the user what he is doing and with which wallet he must be signed in.
  • the user sets the cold wallet - he is signed in with the cold wallet.
  • the user sets the hot wallet and sets the trustline to cold wallet - he is signed in with the hot wallet.
  • the user sends token from cold wallet to hot - he is signed with the cold wallet.
    In the future to make it easier to the user we will enable the fast switch between accounts (we already have the ticket for it).
    Currently the user is signed in and you suggest to sign all transactions with one and the same wallet.
  1. Currently after pressing config button it actually gives no data no refs in data error.
Screenshot 2025-10-10 at 15 28 27 5. The idea of setting the regular keys is not correct. It should not actually be like this.
  1. Currently the page seems broken.
Screenshot 2025-10-11 at 10 26 26
  1. Kindly test the page yourself before the sending for approval.
    Thank you.

@pandablue0809
Copy link
Member Author

@ihomp @Anna15170221
i fix errors.
plz review again. 🙏

@ihomp
Copy link
Member

ihomp commented Nov 21, 2025

@Anna15170221 can you please test again.

@Anna15170221
Copy link
Contributor

Anna15170221 commented Nov 25, 2025

The good news is that I’ve managed to issue tokens using this page. :)

1. Instead of displaying the token image I uploaded, the avatar of the issuer account is being used:
https://test.bithomp.com/en/token/rfjquSFSKXnDYdQyGWuXBSSSW87jfpX7Qm/SMT

https://test.bithomp.com/en/token/rfjquSFSKXnDYdQyGWuXBSSSW87jfpX7Qm/TLT

2. I would optimise the wording otherwise we repeat the same info several times.
Screenshot 2025-11-25 at 11 18 01
My suggestion:
for closed supply:

Step 2: Set Up Issuer (Cold Wallet)
Configure your issuer (cold) wallet by setting the required AccountSet fields
For closed supply, the issuer account will be blackholed — permanently and irreversibly. Proceed with caution.

for open supply:

Step 2: Set Up Issuer (Cold Wallet)
Configure your issuer (cold) wallet by setting the required AccountSet fields.
For open supply, the issuer account won't be blackholed— it must remain active to allow future token issuance and management.

3. If we ask the user to be signed in we need to provide the link to the pop-up with the signing options.

4.
Tick size can't be 1 and 2 so we should not allow to enter these numbers.
And if we don't put the tick size the transaction is rejected. I don't think it should be like this, if he doesn't want to set the tick size he should be allowed to sign the transaction.
5. We don't need to set up the domain for the hot wallet.
6.
I used bithomp.com domain and received the metadata: (@ihomp I think you'd better have a look yourself at the logic and all).

bithomp.com xrp-ledger.toml file

For help understanding this file, see:

https://xrpl.org/xrp-ledger-toml.html

[METADATA]
modified = 2023-11-15T10:06:00.000Z

[[PRINCIPALS]]
name = "Bithomp"
email = "[email protected]"
x = "bithomp"

[[VALIDATORS]]
public_key = "nHB8QMKGt9VB4Vg71VszjBVQnDW3v3QudM4DwFaJfy96bj4Pv9fA"
attestation = "9537FBEBC7A676E8748F9D18FF5BD48662B6D811033F34C807E58B99B91484D22B26F56FC7E6B9B8D2233DD5F0DCF9462C3B264411964A93F0173D512F19F002"
network = "main"
owner_country = "se"
server_country = "FI"
network_asn = 24940
server_location = "HETZNER-AS, DE"
server_cloud = true
unl = "https://vl.xrplf.org"

[[ACCOUNTS]]
address = "rPPHhfSQbHt1t2XPHWAK1HTcjqDg56TzZy"
network = "main"
desc = "Bithomp"

[[ACCOUNTS]]
address = "rKontEGtDju5MCEJCwtrvTWQQqVAw5juXe"
network = "main"
desc = "Validator"

[[TOKENS]]
issuer = "radu5U7fLum2my9fopgiYcYPg1oiJJVyip"
currency = "TST"
name = "TestToken"
desc = "For testing puposes"
icon = "https://bafybeigakqejqxrvxjrcqgj7vezy4rsbxjvh2epd33wcokh4p27cz7ysaa.ipfs.dweb.link?filename=DALL%C2%B7E%202025-01-10%2016.58.43%20-%20A%20refined%20vector%20graphic%20icon%20of%20a%20medal%20featuring%20the%20number%20'1%2B'%20in%20bold%20black%20in%20the%20center.%20The%20medal%20has%20a%20gold%20circular%20design%20with%20a%20polished%20l.webp"
asset_class = "rwa"
asset_subclass = "stablecoin"

7. concerning the blackholed account.
for the closed supply we write that the account will be blackholed but we actually don't suggest the step where the user blackhole it.
Therefore currently there is no difference between issuing with open supply and closed supply.

@Anna15170221
Copy link
Contributor

Anna15170221 commented Nov 25, 2025

@ihomp @pandablue0809
my impression from the page: it's possible now to issue the token - generally it works. But we will need to continue working on it - it's not finalised. For me looks a bit "heavy" and complicated. Probably we need to think all together the ways to optimise it. We need the tool the the users will be willing to use. It should look nice, be intuitively easy. For better user experience we will need to implement the switcher between accounts (separately).

@Anna15170221
Copy link
Contributor

@pandablue0809 Before you continue working on this page, I suggest that @ihomp also reviews it and shares his comments, to avoid doing unnecessary work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants