Add NFT Transfer Option on Xahau Network using the Remit. #550
+84
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Anna15170221 please test this one too |
ihomp
requested changes
Sep 14, 2025
components/SignForm.js
Outdated
| setStatus(t('form.error.address-empty')) | ||
| setFormError(true) | ||
| // For regular NFT transfer offers | ||
| tx.Amount = '0' |
There was a problem hiding this comment.
This is code is exactly the same as for remit, except the amount.. Please don't copy-paste the same code!
if (tx.TransactionType !== 'Remit') {
tx.Amount = '0'
}
|
@ihomp @pandablue0809 |
|
@ihomp |
|
@Anna15170221 can you please test again? |
|
@pandablue0809 @ihomp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We need to add an option, to transfer NFT using the Remit. If destination doesn't have disallowRemitIncoming (allows remit trxs) then we can just send NFT to the destination without asking (but paying for the NFT reserve).