Skip to content

Conversation

pandablue0809
Copy link
Member

@pandablue0809 pandablue0809 requested a review from ihomp August 19, 2025 13:28
@ihomp
Copy link
Member

ihomp commented Sep 14, 2025

@Anna15170221 can you test this one and write your suggestions?

from me: it seems a lot of code was copy pasted from a different component, we shouldn't copy-paste the code, we need to extract it and reuse it.. that way we will keep the code maintanable.

  • the full-screen view - has trouble with scrolling; also, the scrolling button shouldn't be there.
  • the buttons to view full screen and to download music should be in the same style (new style you suggested) ..
  • when we have both audio and image - we have two buttons to view full screen - that shoudn't be the case.

@ihomp
Copy link
Member

ihomp commented Sep 14, 2025

  • why search block css was changed? that can break with some popups scrolling for fixed objects etc.. that is need to be tested well.

Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is a lot of copy-pasted code that needs to be extracted and reused.

@Anna15170221
Copy link
Contributor

@pandablue0809
Screenshot 2025-09-15 at 11 27 58
the buttons are on the image - for me doesn't look nice for desktop
and the mobile view should also be improved I think
Screenshot 2025-09-15 at 11 32 52

http://localhost:3000/en/nft/00083A9836EC5BC756007990B29DBFC81F45460ED8B8583A6442C30600000069 - I tested on this one

@Anna15170221
Copy link
Contributor

@ihomp Slava, popups scrolling for fixed objects - what do you mean here?
that can break with some popups scrolling for fixed objects etc.. that is need to be tested well.

@pandablue0809
Copy link
Member Author

@ihomp
i fixed it. plz review again. 🙏

@pandablue0809 pandablue0809 requested a review from ihomp September 17, 2025 19:30
@ihomp
Copy link
Member

ihomp commented Sep 29, 2025

@ihomp Slava, popups scrolling for fixed objects - what do you mean here? that can break with some popups scrolling for fixed objects etc.. that is need to be tested well.

@pandablue0809 chenaged css for the search block, so the search block on other pages can appear over some popuup windows like choosinga. token or when signing transactions, or when scrolling on a pages, some elemnts can be under the bar or over the bar.. it's dangerous to change such parameters without proper testing on different pages with different scenarious

@ihomp
Copy link
Member

ihomp commented Sep 29, 2025

@ihomp i fixed it. plz review again. 🙏

@Anna15170221 can you test again please

@ihomp ihomp requested a review from Anna15170221 September 29, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants