Skip to content

Escrows - avoid unnecessary api calls #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 23, 2025

Conversation

pandablue0809
Copy link
Member

@pandablue0809 pandablue0809 commented Jul 16, 2025

@pandablue0809 pandablue0809 requested a review from ihomp July 16, 2025 01:29
@ihomp
Copy link
Member

ihomp commented Jul 21, 2025

Please do not copy-paste the same code several times, see the refactoring here:
f85f43d

@ihomp
Copy link
Member

ihomp commented Jul 21, 2025

It seems the escrowSequence is not available... I can't test. @ildaruz
/en/account/wietse the escrowSequence is null in objects / escrows

@ildaruz
Copy link
Member

ildaruz commented Jul 21, 2025

It seems the escrowSequence is not available... I can't test. @ildaruz

/en/account/wietse the escrowSequence is null in objects / escrows

Yep, unfortunately this could happen for some escrows, I need some time to update them

@ihomp
Copy link
Member

ihomp commented Jul 22, 2025

@ildaruz shall we keep the old behavier as a backup (when we send an aditional api call to request the sequence) or are we confident that soon it will be always available?

@ildaruz
Copy link
Member

ildaruz commented Jul 22, 2025

@ildaruz shall we keep the old behavier as a backup (when we send an aditional api call to request the sequence) or are we confident that soon it will be always available?

I recomend to keep it for backup, in case crawler is outdated and we still need it untill sequence is fullfilled

@ihomp
Copy link
Member

ihomp commented Jul 22, 2025

@pandablue0809, please add the older version as backup when no escrowSequence is available.
But extract the api call to a function and reuse it instead of adding the same api call twice in two different places.

Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep the older version as a backup

@pandablue0809 pandablue0809 requested a review from ihomp July 22, 2025 14:31
@pandablue0809
Copy link
Member Author

@ihomp I fixed

@ihomp ihomp merged commit 14a9699 into Bithomp:main Jul 23, 2025
@pandablue0809 pandablue0809 deleted the feat/460/update-escrow branch July 23, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants