-
Notifications
You must be signed in to change notification settings - Fork 22
Escrows - avoid unnecessary api calls #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please do not copy-paste the same code several times, see the refactoring here: |
It seems the |
Yep, unfortunately this could happen for some escrows, I need some time to update them |
@ildaruz shall we keep the old behavier as a backup (when we send an aditional api call to request the sequence) or are we confident that soon it will be always available? |
I recomend to keep it for backup, in case crawler is outdated and we still need it untill sequence is fullfilled |
@pandablue0809, please add the older version as backup when no escrowSequence is available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets keep the older version as a backup
@ihomp I fixed |
This reverts commit eb72580.
Issue