Skip to content

/send page fixes needed #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

@pandablue0809 pandablue0809 requested a review from ihomp July 1, 2025 13:38
@ihomp
Copy link
Member

ihomp commented Jul 8, 2025

We have the same issue for many other pages like in /faucet

the problem here that the component re-renders when the address changes..
the addressDetails are erased when the component addressInput re-renders..
and the addressDetails never leaving the addressInput component...

my seggestion
if we can't get away from component re-render, then we can probably set addressDetails from the addressInput as addressInput already have this data it just doesnt pass it to the parent page.

Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We rather need a universal solution that would work for all other cases as well.

@pandablue0809 pandablue0809 requested a review from ihomp July 14, 2025 02:39
@pandablue0809
Copy link
Member Author

I fixed @ihomp

Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is over-complecated..

  • components requests data, pass it to the page, then page pass it back to a component, when the data is only used inside of the component.
  • you've added the same api request on the page, that already in use in the component, when data is only used on the componnet.

we have a working solution:
https://test.xrplexplorer.com/en/faucet

  • When you specify the address, the username/service name will stay.
  • it's good to trigger add the username/service name for the default value when the value is specified in the url (but within the component)

@ihomp
Copy link
Member

ihomp commented Jul 23, 2025

fixed in ac89189

@ihomp ihomp closed this Jul 23, 2025
@pandablue0809 pandablue0809 deleted the feat/407/addressinput-on-send-page branch July 23, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants