-
Notifications
You must be signed in to change notification settings - Fork 22
/send page fixes needed #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/send page fixes needed #429
Conversation
We have the same issue for many other pages like in /faucet the problem here that the component re-renders when the address changes.. my seggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We rather need a universal solution that would work for all other cases as well.
I fixed @ihomp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is over-complecated..
- components requests data, pass it to the page, then page pass it back to a component, when the data is only used inside of the component.
- you've added the same api request on the page, that already in use in the component, when data is only used on the componnet.
we have a working solution:
https://test.xrplexplorer.com/en/faucet
- When you specify the address, the username/service name will stay.
- it's good to trigger add the username/service name for the default value when the value is specified in the url (but within the component)
fixed in ac89189 |
Issue
On page send payment, when I type address like Bithomp and then choose that in the dropdown, the address is filled. but the username/service name is not on top of the component. it’s there for a second. but then disappears - it would be nice fix that. So the username/service name stays on top of the component when the address is chosen.