Skip to content

Add new 'Add Channel' page for Notifications #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

pavel-fokin
Copy link
Contributor

No description provided.

Copy link
Member

@ihomp ihomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module not found: Can't resolve 'zod'

1 | import { z } from 'zod'

@ihomp
Copy link
Member

ihomp commented Jun 29, 2025

I couldn't test

Module not found: Can't resolve 'zod'
> 1 | import { z } from 'zod'

I don't see in the packages

what do we need it for?

How far we are fro PR here?

Pavel Fokin added 6 commits June 30, 2025 15:54
- Add deletePartnerConnection API function
- Refactor ChannelCard component into modular structure with separate files
- Add ChannelDeleteDialog component for confirmation
- Add useDeleteNotificationChannel hook
- Create reusable Dialog UI component with styling
- Move NOTIFICATION_CHANNEL_TYPES from constants.js to notificationChannels.js
- Update imports to use consolidated notificationChannels module
@pavel-fokin pavel-fokin force-pushed the notifications-add-channel branch from cb0e157 to 93ee5f0 Compare July 1, 2025 11:45
@pavel-fokin pavel-fokin mentioned this pull request Jul 1, 2025
@ihomp
Copy link
Member

ihomp commented Jul 4, 2025

this is still doesn't work for me to test:

  • Module not found: Can't resolve 'zod' import { z } from 'zod' (what do we need this package for?)
  • How far we are fro PR in here?
  • the conflicts need to be solved.

@ihomp ihomp marked this pull request as ready for review August 10, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants