-
Notifications
You must be signed in to change notification settings - Fork 22
Add new 'Add Channel' page for Notifications #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pavel-fokin
wants to merge
9
commits into
Bithomp:main
Choose a base branch
from
pavel-fokin:notifications-add-channel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihomp
approved these changes
Jun 29, 2025
ihomp
requested changes
Jun 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module not found: Can't resolve 'zod'
1 | import { z } from 'zod'
I couldn't test
I don't see in the packages what do we need it for? How far we are fro PR here? |
- Add deletePartnerConnection API function - Refactor ChannelCard component into modular structure with separate files - Add ChannelDeleteDialog component for confirmation - Add useDeleteNotificationChannel hook - Create reusable Dialog UI component with styling - Move NOTIFICATION_CHANNEL_TYPES from constants.js to notificationChannels.js - Update imports to use consolidated notificationChannels module
cb0e157
to
93ee5f0
Compare
Merged
this is still doesn't work for me to test:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.