export csv for coin ledger #245

juddydev · 2025-03-28T07:29:27Z

No description provided.

ihomp · 2025-03-30T01:53:04Z

pages/admin/pro/history.js

              <br />
-              <br />
-              Let us know if we miss koinlyIDs for your tokens. We will add them to the system.
+              Let us know if we miss koinlyIDs for your tokens. We will add them to the system. */}


Why did you comment it? the text should be visible when koinly is chosen

Got it I'll updated this

ihomp · 2025-03-30T01:54:08Z

pages/admin/pro/history.js

@@ -252,10 +310,10 @@ export default function History({ queryAddress, selectedCurrency, setSelectedCur

        res.activities[i].timestampExport = new Date(res.activities[i].timestamp * 1000).toISOString()

-        res.activities[i].sentAmount = sending ? res.activities[i].amountNumber : 0
+        res.activities[i].sentAmount = sending ? res.activities[i].amountNumber : ""


that is a dangerous chnage that can brake csv for koinly.. was that tested?

I have tested this
We can import it into Koinly
I have imported into Koinly successfully !

koinly.csv

juddydev · 2025-03-31T16:50:54Z

Export CSV file for CoindLedger platform => SOLVED

@ihomp could you check this?

export-csv-coinledger.mp4

ihomp · 2025-04-12T07:15:12Z

pages/admin/pro/history.js

        res.activities[i].receivedCurrency = !sending ? scvCurrency : ''

        res.activities[i].netWorthCurrency = selectedCurrency.toUpperCase()

        //sanitize memos for CSV
        res.activities[i].memo = res.activities[i].memo?.replace(/"/g, "'") || ''
+
+        // For CoinLedger platform
+        res.activities[i].coinLedgerTxType = res.activities[i].direction === 'sent' ? 'Withdrawal' : res.activities[i].direction === 'received' ? 'Deposit' : res.activities[i].txType


we should not rely on "direction", it should rely on the "amount".

if positive amount -> Deposit

if negative balance -> Withdrawl

Are there any other options available?
Because if only fee was paid it's not widtrawal. it's network fee, it should be an option for that.

then if the negative balance is less or equal the fee - then it's "Fee" or equvalent

ihomp · 2025-04-12T07:18:04Z

the "direction" should not be used for the balance changes types

ihomp · 2025-04-12T07:20:50Z

pages/admin/pro/history.js

@@ -29,7 +29,9 @@ import Image from 'next/image'
 import { CSVLink } from 'react-csv'
 import DownloadIcon from '../../../public/images/download.svg'
 import { koinly } from '../../../utils/koinly'
-
+import { format } from 'date-fns'


why do we need 'date-fns' in here?
JS functions not enough to format a date?

The project doesn't have date-fns installed, and I don't see the package is added in the package.json and yarn.lock

it's nice sometimes to avoid installing new packages, and just replace them with a function.

ihomp · 2025-04-12T07:31:43Z

pages/admin/pro/history.js

+  CoinLedger: (timestamp) => {
+    // Format: MM/DD/YYYY HH:MM:SS in UTC
+    const date = new Date(timestamp * 1000);
+    return format(new Date(date.getTime() + date.getTimezoneOffset() * 60000), 'MM/dd/yyyy HH:mm:ss');


would this work from unix seconds to format they need in utc?

function formatUnixToUTC(unixSeconds) { const date = new Date(unixSeconds * 1000); // Convert to milliseconds const pad = (n) => n.toString().padStart(2, '0'); const mm = pad(date.getUTCMonth() + 1); const dd = pad(date.getUTCDate()); const yyyy = date.getUTCFullYear(); const hh = pad(date.getUTCHours()); const min = pad(date.getUTCMinutes()); const ss = pad(date.getUTCSeconds()); return `${mm}/${dd}/${yyyy} ${hh}:${min}:${ss}`; }

ihomp · 2025-04-12T07:34:11Z

pages/admin/pro/history.js

@@ -222,7 +280,7 @@ export default function History({ queryAddress, selectedCurrency, setSelectedCur
        let sending = res.activities[i].amountInFiats?.[selectedCurrency]?.[0] === '-'
        res.activities[i].index = options?.marker ? activities.length + 1 + i : i + 1
        res.activities[i].amountExport = amountFormat(res.activities[i].amount)
-        res.activities[i].amountNumber = res.activities[i].amount?.value || res.activities[i].amount / 1000000
+        res.activities[i].amountNumber = res.activities[i].amount?.value || (parseFloat(res.activities[i].amount) / 1000000)


didn't it work without parseFloat? it is string, but it's always integer

juddydev · 2025-04-14T19:21:45Z

@ihomp Are there any other options available?
Because if only fee was paid it's not widtrawal. it's network fee, it should be an option for that.

then if the negative balance is less or equal the fee - then it's "Fee" or equvalent

=> CoinLedger also support Fee Tx type

ihomp · 2025-04-15T22:17:42Z

=> CoinLedger also support Fee Tx type

So, why did you remove the "Fee" option in your last commit?

ihomp · 2025-04-15T22:19:36Z

pages/admin/pro/history.js

+                  data={processDataForExport(filteredActivities || [], platformCSVExport)}
+                  headers={
+                    platformCSVHeaders.find(
+                      (header) => header.platform.toLowerCase() === platformCSVExport.toLocaleLowerCase()


toLocaleLowerCase?
did you mean the toLowerCase?

I'll update this right now

juddydev · 2025-04-15T22:55:25Z

=> CoinLedger also support Fee Tx type

So, why did you remove the "Fee" option in your last commit?

CoinLedger also support Fee tx type but It's only for Manual Input
But we need to import through CSV file so TX type "Fee" currently not supported. I have tried
It just only support some these transaction type

So I think Fee also use Withdrawal TX Type
It's the best choice currently I think

ihomp

@Anna15170221 the code looks good for me now.
If CSV imports works well for both platforms, we can merge it and give to some users to test.

juddydev added 2 commits March 28, 2025 16:28

export csv for coin ledger

097b66c

update null for empty vaule instead of 0

7d300c3

ihomp reviewed Mar 30, 2025

View reviewed changes

add koinly desc

11d20d9

juddydev requested a review from ihomp March 30, 2025 16:40

change type of tx for coinledger base on direction

78e397e

ihomp reviewed Apr 12, 2025

View reviewed changes

update export csv coinledger

d734a1a

remove fee tx type

836c368

ihomp requested changes Apr 15, 2025

View reviewed changes

update platfrom compare

f8033a3

juddydev requested a review from ihomp April 15, 2025 23:42

ihomp approved these changes Apr 18, 2025

View reviewed changes

ihomp merged commit c24ff32 into Bithomp:main Apr 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

export csv for coin ledger #245

export csv for coin ledger #245

juddydev commented Mar 28, 2025

ihomp Mar 30, 2025

juddydev Mar 30, 2025

ihomp Mar 30, 2025

juddydev Mar 30, 2025

juddydev commented Mar 31, 2025

ihomp Apr 12, 2025

ihomp commented Apr 12, 2025

ihomp Apr 12, 2025

ihomp Apr 12, 2025

ihomp Apr 12, 2025

ihomp Apr 12, 2025

juddydev commented Apr 14, 2025

ihomp commented Apr 15, 2025

ihomp Apr 15, 2025

juddydev Apr 15, 2025

juddydev commented Apr 15, 2025

ihomp left a comment

export csv for coin ledger #245

export csv for coin ledger #245

Conversation

juddydev commented Mar 28, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juddydev commented Mar 31, 2025

Choose a reason for hiding this comment

ihomp commented Apr 12, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juddydev commented Apr 14, 2025

ihomp commented Apr 15, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juddydev commented Apr 15, 2025

ihomp left a comment

Choose a reason for hiding this comment