Fix toolkit build and address decoding - #3
Open
newmattock wants to merge 2 commits into
Open
Conversation
|
Review-assist note for the Bitgesell #81 improvement lane. I checked the public PR body and diff. This looks like a build/test reliability and typed-response decoding repair for the official Go toolkit:
Suggested maintainer checks before merge:
From the public patch shape, this is a meaningful #81 candidate because it turns build breakage and empty decoded results into testable behavior without requiring secrets, wallets, live nodes, or chain actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
go test ./...builds the examples package.Related bounty or issue:
Baseline failure before fix:
go test ./...failed with duplicateSDKConfigdeclarations, undefinedobjecttypes, invalid example imports/usages, and missing transaction client fields.Validation:
go test ./...make setup && make compilegit diff --checkNotes:
.github/workflows/build.ymlcommands.