Ci add missing node version spec to enforce consistency with package.json#418
Open
clintjeff2 wants to merge 2 commits into
Conversation
…s-for-ci ci: enforce Node 22 runtime
|
Contributor
Author
|
@leocagli, review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
@types/node: "^22"and is tested locally with Node 22, but CI used Node 20 which caused install/test mismatches and CI failures.Description
engines.node: ">=22.0.0"topackage.jsonto declare the required Node runtime..github/workflows/ci.ymlto usenode-version: 22for the CIsetup-nodestep..nvmrcwith22sonvmusers pick Node 22 automatically..node-versionwith22for tools that read that file (Volta, nodenv, etc.).Testing
node -e "..."that checkspackage.json.engines.node,.nvmrc,.node-version, and that the CI workflow containsnode-version: 22, and it exited successfully.git diff --checkand found no whitespace or diff issues.Closes #224