Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

login button working #217

Merged
merged 3 commits into from
Oct 25, 2024
Merged

login button working #217

merged 3 commits into from
Oct 25, 2024

Conversation

AyushSharma72
Copy link
Contributor

@AyushSharma72 AyushSharma72 commented Oct 23, 2024 •
edited
Loading

now the login button is making request to the backend

I added wrong credentials for demo purpose

Screenshot (280)

please add gssoc-ext and level1 before merge @Anuj3553

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Harshit7492
Copy link
Collaborator

Hyy @AyushSharma72 i am @Harshit7492 please add a screehshot with correct credentials

@Harshit7492 Harshit7492 added gssoc-ext Extended contribution for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level1 Beginner-level contribution or task hacktoberfest Open-source contribution during October for GSSoC labels Oct 24, 2024
@Harshit7492
Copy link
Collaborator

This will be easy to merge you PR

@AyushSharma72
Copy link
Contributor Author

AyushSharma72 commented Oct 24, 2024 •
edited
Loading

Hyy @AyushSharma72 i am @Harshit7492 please add a screehshot with correct credentials

the issue was that it was not making an api call to the backend now it is doing if i add correct credentials it will log me in
@Harshit7492

here:
image

@AyushSharma72
Merge branch 'main' into new
352dcc6 
Signed-off-by: Ayush Sharma <[email protected]>
@Harshit7492 Harshit7492 self-requested a review October 24, 2024 09:05
@Harshit7492 Harshit7492 removed their request for review October 24, 2024 09:18
@AyushSharma72
Merge branch 'main' into new
929a88b 
Signed-off-by: Ayush Sharma <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Oct 24, 2024 •
edited
Loading

👷 Deploy request for bitbox-in accepted.

Name Link
🔨 Latest commit 929a88b
🔍 Latest deploy log https://app.netlify.com/sites/bitbox-in/deploys/671a211c0336690008cad6fc

@AyushSharma72
Copy link
Contributor Author

AyushSharma72 commented Oct 24, 2024 •
edited
Loading

Hyy @AyushSharma72 i am @Harshit7492 please add a screehshot with correct credentials

the issue was that it was not making an api call to the backend now it is doing if i add correct credentials it will log me in @Harshit7492

here: image

please merge this pr @Harshit7492 any problem @Harshit7492 ??? if not please merge

@Anuj3553 Anuj3553 self-requested a review October 25, 2024 16:26
@Anuj3553 Anuj3553 merged commit d2b078f into Bitbox-Connect:main Oct 25, 2024
@Anuj3553
Copy link
Collaborator

Well done @AyushSharma72

@github-actions GitHub Actions
Copy link

🎉🎉 Thank you for your contribution! Your PR #217 has been merged! 🎉🎉

@AyushSharma72 AyushSharma72 deleted the new branch October 30, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anuj3553 Anuj3553 Awaiting requested review from Anuj3553

Assignees

@AyushSharma72 AyushSharma72

Labels
gssoc-ext Extended contribution for GSSoC hacktoberfest Open-source contribution during October for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level1 Beginner-level contribution or task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyushSharma72 @Harshit7492 @Anuj3553