ci: modify release.yaml to work with npm Trusted Publishing #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| uses: semantic-release-action/typescript/.github/workflows/release.yml@1d40c29e2d500f3bcceeb13f95d26a3a1b571f51 # v3.0.20 | ||
| secrets: | ||
| npm-token: ${{ secrets.NPM_TOKEN }} | ||
| npm-token: "n/a" |
There was a problem hiding this comment.
What is this? Why is this variable set to a non-secret instead of being removed?
There was a problem hiding this comment.
When I completely removed it, I was getting a "missing npm token" error.
I'm assuming the version of semantic release we are running expects there to be an npm token.
So to bypass this error I just added a dummy value - my apologies, I should have explained the reason why that was necessary.
Please let me know if you want me to approach this differently, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates the GitHub Actions release workflow to use npm Trusted Publishing (OIDC) instead of long-lived
NPM_TOKENsecrets.Changes:
id-token: writefor OIDC-based publishing.NPM_TOKENfrom the release job.Why:
This change aligns with BitGo’s initiative to eliminate long-lived tokens and use GitHub’s OIDC-based authentication for npm publishing.
Trusted Publishers were configured in npmjs for all relevant repos.
Expected outcome:
Ticket: DX-2084