fix: mitigate CVE-2024-48930 by validating secp256k1 curve points, enforce secp256k1 v5.0.1 #7122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starfy84
force-pushed
the
DX-1569-secp256k1
branch
3 times, most recently
from
1d439ae to
4c05025
Compare
…force secp256k1 v5.0.1 TICKET: DX-1569
starfy84
force-pushed
the
DX-1569-secp256k1
branch
from
4c05025 to
f1efd88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: DX-1569
This PR adds overrides to enforce secp256k1 v5.0.1. It also adds some additional curve validation.
Testing
yarn run unit-testpassesnpm ls secp256k1no longer shows conflicts