Skip to content

feat(express): migrate update keychain passphrase to typed routes #7106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(express): migrate update keychain passphrase to typed routes #7106

wants to merge 4 commits into from

Conversation

danielzhao122
Copy link
Contributor

TICKET: WP-5417

@danielzhao122 danielzhao122 requested a review from a team as a code owner September 26, 2025 16:03
zahin-mohammad
zahin-mohammad reviewed Sep 29, 2025
View reviewed changes
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Ping me once the merge conflicts are fixed.

zahin-mohammad
zahin-mohammad previously approved these changes Oct 1, 2025
View reviewed changes
sasikumar-bitgo
sasikumar-bitgo reviewed Oct 2, 2025
View reviewed changes
zahin-mohammad
zahin-mohammad previously approved these changes Oct 3, 2025
View reviewed changes
sasikumar-bitgo
sasikumar-bitgo previously approved these changes Oct 6, 2025
View reviewed changes
@danielzhao122 danielzhao122 requested a review from a team as a code owner October 6, 2025 23:42
zahin-mohammad
zahin-mohammad reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to rebase your PR for CI fixes.

@danielzhao122 danielzhao122 force-pushed the WP-5417-express-migrate-api-v2-coin-keychain-id-changepassword-to-typed-route branch from 8d0353d to 83e9658 Compare October 9, 2025 01:13
zahin-mohammad
zahin-mohammad approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Lets make sure to test this route locally as well.

  • use express to change passphrase for a new wallets key
  • try to withdraw from the wallet using your new passphrase (either ui or via the sdk)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zahin-mohammad zahin-mohammad zahin-mohammad approved these changes

@sasikumar-bitgo sasikumar-bitgo sasikumar-bitgo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielzhao122 @zahin-mohammad @sasikumar-bitgo