refactor: migrated generateWallet to typed routes #7052
Conversation
danielzhao122
force-pushed
the
WP-5415-express-migrate-api-v2-coin-wallet-generate-to-typed-routes
branch
from
16a0cd0 to
96dd8d5
Compare
| const coin = bitgo.coin(req.decoded.coin); | ||
| const result = await coin.wallets().generateWallet(req.body); | ||
| if (req.query.includeKeychains === 'false') { | ||
| if ((req.decoded.includeKeychains as any) === false) { |
There was a problem hiding this comment.
Why are we casting to any here?
There was a problem hiding this comment.
This is because includeKeychains is type BooleanFromString which has output type string so statically it is typed as a string but during runtime it is actually a boolean. I think this is because of how we setup the decoder.
Also includeKeychains is a parameter in the request and httpRequest requires that params are of type string
danielzhao122
force-pushed
the
WP-5415-express-migrate-api-v2-coin-wallet-generate-to-typed-routes
branch
from
fb1254e to
678e891
Compare
| /** If absent, BitGo uses the default wallet type for the asset */ | ||
| multisigType: multisigType, |
There was a problem hiding this comment.
The command and the codec here seem to conflict. The codec makes this a required field. The comment says this should be optional.
| /** The type of wallet, defined by key management and signing protocols. 'hot' and 'cold' are both self-managed wallets. If absent, defaults to 'hot' */ | ||
| type: walletType, |
| /** Wallet label */ | ||
| label: t.string, | ||
| /** Enterprise id. This is required for Ethereum wallets since they can only be created as part of an enterprise */ | ||
| enterprise: t.string, |
There was a problem hiding this comment.
Enterprise is optional in GenerateWalletOptions
There was a problem hiding this comment.
I think this might actually be required, but to avoid introducing a breaking change for this change we should map the codec to what GenerateWalletOptions defines.
2 participants
added keychain codecs to a general codec file, as I assume that these codecs could be reused (but not sure if they will). refactored the UT that covered generateWallet to ensure that encoding and decoding works e2e.
TICKET: WP-5415