Skip to content

fix: Remove deprecated requests and requests-promise dependencies - replaced one requests-promise usage with superagent. #6955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Remove deprecated requests and requests-promise dependencies - replaced one requests-promise usage with superagent. #6955

wants to merge 1 commit into from
+28 −57

Conversation

bmbenson-miaxdx
Copy link

@bmbenson-miaxdx bmbenson-miaxdx commented Sep 11, 2025 •
edited
Loading

Description

fix: Remove deprecated requests and requests-promise dependencies - replaced one requests-promise usage with superagent.

Issue Number

#6051

Type of change

  • Bug fix - remove long deprecated packages.

@bmbenson-miaxdx
fix: Remove deprecated requests and requests-promise dependencies - r…
4dffac5 
…eplaced one requests-promise usage with superagent.
@bmbenson-miaxdx bmbenson-miaxdx requested review from a team as code owners September 11, 2025 14:19
Taseen08
Taseen08 reviewed Oct 10, 2025
View reviewed changes
Copy link

@Taseen08 Taseen08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but merge conflicts

@bmbenson-miaxdx
Copy link
Author

Looks like someone did something very similar using axios already - so we can just close this one out.
https://github.com/BitGo/BitGoJS/blob/master/modules/bitgo/test/unit/bitgo.ts#L14

mukeshsp
mukeshsp reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@mukeshsp mukeshsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the conflict

lokesh-bitgo
lokesh-bitgo reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

@lokesh-bitgo lokesh-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to re-request once the merge conflict is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mukeshsp mukeshsp mukeshsp left review comments

@Taseen08 Taseen08 Taseen08 left review comments

@lokesh-bitgo lokesh-bitgo lokesh-bitgo left review comments

@andrew-scott-fischer andrew-scott-fischer andrew-scott-fischer approved these changes

@louib louib louib approved these changes

@therealdwright therealdwright therealdwright approved these changes

@LukeZhang0826 LukeZhang0826 Awaiting requested review from LukeZhang0826 LukeZhang0826 is a code owner automatically assigned from BitGo/wallet-platform

@sasikumar-bitgo sasikumar-bitgo Awaiting requested review from sasikumar-bitgo sasikumar-bitgo is a code owner automatically assigned from BitGo/wallet-platform

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bmbenson-miaxdx @andrew-scott-fischer @louib @therealdwright @mukeshsp @Taseen08 @lokesh-bitgo