Skip to content

feat(statics): use const instead of enum #6541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhahn2003
Copy link
Contributor

BREAKING CHANGE: enums used in statics/src/base are changed to const, both the object and type are still exported but cannot rely on them being enums

TICKET: CAAS-325

@mhahn2003 mhahn2003 force-pushed the CAAS-325-enum-to-const branch from 230a887 to 88103f3 Compare July 24, 2025 18:57
@mhahn2003 mhahn2003 force-pushed the CAAS-325-enum-to-const branch from 88103f3 to f52bc45 Compare July 24, 2025 19:11
BREAKING CHANGE: enums used in `statics/src/base` are changed to const, both the object and type are still exported but cannot rely on them being enums

TICKET: CAAS-325
@mhahn2003 mhahn2003 force-pushed the CAAS-325-enum-to-const branch from f52bc45 to 44cbb1e Compare July 24, 2025 19:50
@mhahn2003 mhahn2003 marked this pull request as ready for review July 24, 2025 21:52
@mhahn2003 mhahn2003 requested review from a team as code owners July 24, 2025 21:52
Copy link
Contributor

@mullapudipruthvik mullapudipruthvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain why are you doing this change?
and what is the client expected to change on their end ?

Copy link
Contributor

@OttoAllmendinger OttoAllmendinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not convinced we need this. I'm sure we can run this typescript code with node24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants