Skip to content

feat: enable CLV level rewards by default#30

Open
CroaBeast wants to merge 5 commits into
masterfrom
croabeast
Open

feat: enable CLV level rewards by default#30
CroaBeast wants to merge 5 commits into
masterfrom
croabeast

Conversation

@CroaBeast
Copy link
Copy Markdown
Collaborator

@CroaBeast CroaBeast commented May 20, 2026

Summary

  • bump version to 1.2.5
  • match CLV tab command permissions
  • enable level rewards by default

Commits

  • chore: bump version to 1.2.5
  • fix: match CLV tab command permissions
  • feat: enable CLV level rewards by default

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

@CroaBeast CroaBeast requested a review from Klema4 May 20, 2026 20:37
@review-me-code
Copy link
Copy Markdown

Pull request overview

Bumps version to 1.2.5, updates CLV tab completer to use lowercase command keys and support console senders, and enables level rewards by default in config.

Changes:

  • build.gradle.kts: bump version to 1.2.5
  • CLVTabComplete.java: add CONSOLE_COMMANDS list with lowercase command names
  • CLVTabComplete.java: change COMMAND_PERMISSIONS keys from camelCase to lowercase
  • CLVTabComplete.java: update onTabComplete to handle non-player senders with null player check
  • CLVTabComplete.java: adjust permission checks for 'info' and 'purge' args[1] cases
  • config.yml: change add-level-reward from false to true

Reviewed changes

  • Medium src/main/java/com/bitaspire/cyberlevels/command/CLVTabComplete.java - Verify command handler key names match lowercase
    COMMAND_PERMISSIONS keys are changed from camelCase ('addExp') to lowercase ('addexp'). Ensure command handler registration uses the same lowercase keys, otherwise tab completion and actual command execution will be out of sync.
  • Low src/main/java/com/bitaspire/cyberlevels/command/CLVTabComplete.java - Console 'info' command won't complete player names
    Console can trigger 'info' (it's in COMMAND_PERMISSIONS) but when args.length==2 and args[0]=='info', the check player != null && player.hasPermission(...) will block player name completion for console senders. This may be intentional, but confirm it's desired behavior.

Reviewed 3 changed files in this pull request and generated no inline comments.


Generated by pull_request.opened.

Copy link
Copy Markdown
Collaborator

@Klema4 Klema4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants