Skip to content

fix: update sponsor information and last updated date#39

Open
Bistutu wants to merge 1 commit intomainfrom
pr-38
Open

fix: update sponsor information and last updated date#39
Bistutu wants to merge 1 commit intomainfrom
pr-38

Conversation

@Bistutu
Copy link
Owner

@Bistutu Bistutu commented Mar 4, 2026

Summary by Sourcery

Update sponsor metadata and documentation to reflect the latest sponsor list and last updated date.

Enhancements:

  • Update in-app sponsor hint text and sponsor data to match the latest top-10 sponsors and last updated date.

Documentation:

  • Refresh README sponsor section with updated last updated date and revised top-10 sponsor table.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 4, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates sponsor-related display text and data to reflect a new last-updated date and refreshed top-10 sponsor list, keeping the Vue app and README in sync.

File-Level Changes

Change Details Files
Refresh sponsor hint copy and last-updated date in the Vue app i18n configuration.
  • Update English sponsorHint string to show last updated date as 2026.3.5
  • Update Chinese sponsorHint string to show last updated date as 2026.3.5
static/src/App.vue
Update sponsor ranking data to new top-10 list while preserving structure.
  • Replace sponsors ranked 4–10 with new ordered list, including a new sponsor '静' at rank 4 with amount 100
  • Shift previous sponsors down one rank and remove the anonymous user from the top 10
static/src/App.vue
Keep README sponsor description and table in sync with in-app sponsor data and last-updated date.
  • Update Chinese sponsor description line to use last updated date 2026.3.5
  • Update README sponsor ranking table rows 4–10 to match the new sponsor list and amounts used in the app
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • The sponsor list and last-updated date are duplicated in both App.vue and README.md; consider centralizing this data (e.g., in a JSON or config file) so that future updates only need to be made in one place.
  • You may want to standardize the date format (e.g., 2026-03-05 or locale-aware formatting) rather than hardcoding a free-form string inside the translatable text, which will make future updates and localization easier.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The sponsor list and last-updated date are duplicated in both `App.vue` and `README.md`; consider centralizing this data (e.g., in a JSON or config file) so that future updates only need to be made in one place.
- You may want to standardize the date format (e.g., `2026-03-05` or locale-aware formatting) rather than hardcoding a free-form string inside the translatable text, which will make future updates and localization easier.

## Individual Comments

### Comment 1
<location path="static/src/App.vue" line_range="266-267" />
<code_context>
   sponsorHint: {
-    en: 'The website is free, open-source, and kept simple. If you want to support the author, please scan the sponsor code with WeChat. Below are the top 10 sponsors (last updated on 2025.1.21)',
-    zh: '网站免费、开源、保持简单,如果你想支持作者,请使用微信扫描赞赏码,以下是赞赏榜的前10名赞助者(最后更新 2025.9.10)',
+    en: 'The website is free, open-source, and kept simple. If you want to support the author, please scan the sponsor code with WeChat. Below are the top 10 sponsors (last updated on 2026.3.5)',
+    zh: '网站免费、开源、保持简单,如果你想支持作者,请使用微信扫描赞赏码,以下是赞赏榜的前10名赞助者(最后更新 2026.3.5)',
   },
   no: {
</code_context>
<issue_to_address>
**suggestion:** Avoid hardcoding the 'last updated' date in localized strings to reduce maintenance overhead.

The date is duplicated in both English and Chinese strings, so it must be updated in multiple places each time sponsor data changes. Instead, derive it from a single source (e.g., a `sponsorLastUpdated` constant or sponsor data) and interpolate it into the localized strings to keep them in sync automatically.

Suggested implementation:

```
  sponsorHint: {
    en: `The website is free, open-source, and kept simple. If you want to support the author, please scan the sponsor code with WeChat. Below are the top 10 sponsors (last updated on ${sponsorLastUpdated})`,
    zh: `网站免费、开源、保持简单,如果你想支持作者,请使用微信扫描赞赏码,以下是赞赏榜的前10名赞助者(最后更新 ${sponsorLastUpdated})`,
  },

```

To fully implement this, you also need to introduce a single source of truth for `sponsorLastUpdated`:

1. If this file uses a normal `<script>` block with `export default`:
   - Add a module-level constant near the top of the script:
     ```js
     const sponsorLastUpdated = '2026.3.5';
     ```
   - Place it just after `<script>` and before `export default { ... }`.

2. If this file uses `<script setup>`:
   - Add the same constant inside the `<script setup>` block:
     ```js
     const sponsorLastUpdated = '2026.3.5';
     ```

3. For a more robust solution, consider deriving `sponsorLastUpdated` from your sponsor data (e.g., a `lastUpdated` field on the sponsor list) instead of hardcoding `'2026.3.5'`. In that case, ensure `sponsorLastUpdated` is computed once and reused in the sponsorHint strings.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +266 to +267
en: 'The website is free, open-source, and kept simple. If you want to support the author, please scan the sponsor code with WeChat. Below are the top 10 sponsors (last updated on 2026.3.5)',
zh: '网站免费、开源、保持简单,如果你想支持作者,请使用微信扫描赞赏码,以下是赞赏榜的前10名赞助者(最后更新 2026.3.5)',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Avoid hardcoding the 'last updated' date in localized strings to reduce maintenance overhead.

The date is duplicated in both English and Chinese strings, so it must be updated in multiple places each time sponsor data changes. Instead, derive it from a single source (e.g., a sponsorLastUpdated constant or sponsor data) and interpolate it into the localized strings to keep them in sync automatically.

Suggested implementation:

  sponsorHint: {
    en: `The website is free, open-source, and kept simple. If you want to support the author, please scan the sponsor code with WeChat. Below are the top 10 sponsors (last updated on ${sponsorLastUpdated})`,
    zh: `网站免费、开源、保持简单,如果你想支持作者,请使用微信扫描赞赏码,以下是赞赏榜的前10名赞助者(最后更新 ${sponsorLastUpdated})`,
  },

To fully implement this, you also need to introduce a single source of truth for sponsorLastUpdated:

  1. If this file uses a normal <script> block with export default:

    • Add a module-level constant near the top of the script:
      const sponsorLastUpdated = '2026.3.5';
    • Place it just after <script> and before export default { ... }.
  2. If this file uses <script setup>:

    • Add the same constant inside the <script setup> block:
      const sponsorLastUpdated = '2026.3.5';
  3. For a more robust solution, consider deriving sponsorLastUpdated from your sponsor data (e.g., a lastUpdated field on the sponsor list) instead of hardcoding '2026.3.5'. In that case, ensure sponsorLastUpdated is computed once and reused in the sponsorHint strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant