Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearml logger + improved mnist starter #330

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

shatz01
Copy link
Collaborator

@shatz01 shatz01 commented Aug 1, 2023

start_clearml_logger now uses RANK
simple_mnist_example now uses jsonargparse which is prettier and really flexible
requirements.txt added jsonargparse

@shatz01 shatz01 requested a review from mosheraboh August 1, 2023 13:29
mosheraboh
mosheraboh previously approved these changes Aug 2, 2023
Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shatz01 shatz01 merged commit a16bade into master Aug 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants