Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpTranspose (not critical) #222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shatz01
Copy link
Collaborator

@shatz01 shatz01 commented Nov 30, 2022

Had an issue when integrating perceiver architechture that all the implementations require channels to be the last input dim of the minibatch. This required me transposing after OpToTensor in isic dataloader.

This can also be done using OpLambda and passing torch.transpose just as easily, so its not a very necessary pull request. Only merge this if you want to @mosheraboh

Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smartdanny
We do have ops OpCHWToHWC and OpHWCToCHW.
I think that it could be more general.
I thought about implementing op that moves from "channels first" to "channels last' format (and vice versa) even if it's not an image. What do you think?
@SagiPolaczek, we didn't implement it yet, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants