Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove opencv version limitation #169

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Conversation

mosheraboh
Copy link
Collaborator

No description provided.

@mosheraboh mosheraboh requested a review from vagenas August 26, 2022 12:53
@mosheraboh mosheraboh requested a review from vagenas August 28, 2022 09:58
Copy link
Collaborator

@vagenas vagenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for addressing the CVE-2019-5064 vulnerability issue.

@mosheraboh I would actually like us to review the dependency management mechanism (e.g. the interaction between the setuptools configuration –currently setup.py– and the various requirements.txt files), but let us do this separately without blocking this fix.

@mosheraboh
Copy link
Collaborator Author

Thanks @vagenas, would be happy to talk about the dependency management mechanism.

@mosheraboh mosheraboh merged commit f6dfee0 into master Aug 30, 2022
@mosheraboh mosheraboh deleted the remove-opencv-version-limitation branch August 30, 2022 06:28
@vagenas
Copy link
Collaborator

vagenas commented Nov 14, 2022

FYI @mosheraboh, created an issue for the dependency management point: #212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants