Fix regression on enum34 versioning
#226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BingAds v13.0.14 has a regression in the versioning for `enum34`. This causes `pip install bingads==13.0.14` to break on Python versions `>=3.4,<3.9`, as it interferes with the `enum` system library. Solution is to revert the change to the `enum34` versioning in `setup.py`. For reference, see: * #105 * 25fa4f4 * https://github.com/BingAds/BingAds-Python-SDK/blame/13ae4fde11df8317083038a998ede49f4f9af1f2/setup.py#L18
Author
|
Closing this as we were able to get a workaround by upgrading |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bing Ads SDK v13.0.14 has a regression in the versioning for
enum34. This causespip install bingads==13.0.14to break on Python versions>=3.4,<3.9, as it interferes with theenumsystem library.Solution is to revert the change to the
enum34versioning insetup.py.For reference, see: