Improve flow for resolveIndexAttributes (#532)

BinarCode · Jan 20, 2023 · 9aa97d6 · 9aa97d6
1 parent f62d60f
commit 9aa97d6
Showing 1 changed file with 19 additions and 20 deletions.
diff --git a/src/Repositories/Repository.php b/src/Repositories/Repository.php
@@ -436,28 +436,11 @@ public function resolveShowAttributes(RestifyRequest $request)
      */
     public function resolveIndexAttributes($request)
     {
-        // Resolve the show method, and attach the value to the array
-        $fields = $this
-            ->collectFields($request)
-            ->when($this->hasCustomColumns(), fn (FieldCollection $fields) => $fields->inList($this->getColumns()))
-            ->forIndex($request, $this)
-            ->filter(fn (Field $field) => $field->authorize($request))
-            ->when(
-                $this->eagerState,
-                function ($items) {
-                    return $items->filter(fn (Field $field) => ! $field instanceof EagerField);
-                }
-            )
-            ->each(fn (Field $field) => $field->resolveForIndex($this))
-            ->map(fn (Field $field) => $field->serializeToValue($request))
-            ->mapWithKeys(fn ($value) => $value)
-            ->all();
-
         if ($this instanceof Mergeable) {
             // Hidden and authorized index fields
-            $fields = $this->modelAttributes($request)
+            return $this->modelAttributes($request)
                 ->filter(function ($value, $attribute) use ($request) {
-                    /** * @var Field $field */
+                    /** @var Field $field */
                     $field = $this->collectFields($request)->firstWhere('attribute', $attribute);
 
                     if (is_null($field)) {
@@ -476,7 +459,23 @@ function ($items) {
                 })->all();
         }
 
-        return $fields;
+        // Resolve the show method, and attach the value to the array
+        return $this
+            ->collectFields($request)
+            ->when(
+                $this->hasCustomColumns(),
+                fn (FieldCollection $fields) => $fields->inList($this->getColumns())
+            )
+            ->forIndex($request, $this)
+            ->filter(fn (Field $field) => $field->authorize($request))
+            ->when(
+                $this->eagerState,
+                fn ($items) => $items->filter(fn (Field $field) => ! $field instanceof EagerField)
+            )
+            ->each(fn (Field $field) => $field->resolveForIndex($this))
+            ->map(fn (Field $field) => $field->serializeToValue($request))
+            ->mapWithKeys(fn ($value) => $value)
+            ->all();
     }
 
     public function resolveShowMeta($request)