Feat/use stripe customer portal #185
Conversation
kuboschek
commented
Jul 31, 2025
kuboschek
commented
- Use Stripe Checkout for signups
- Use Stripe Customer Portal for adjusting subscriptions
tkw1536
left a comment
tkw1536
left a comment
There was a problem hiding this comment.
Looks good in principle, except for the minor comments.
alumni/fields/tier.py
Outdated
| @staticmethod | ||
| def get_tier_from_stripe_id(stripe_id: str) -> str: | ||
| """Maps a Stripe plan ID to a membership tier.""" | ||
| stripe_to_tier_map = { |
There was a problem hiding this comment.
Shouldn't this be a global map (as in outsider the function)?
| pass | ||
|
|
||
|
|
||
| class CancellablePaymentMethodForm(PaymentMethodForm): |
There was a problem hiding this comment.
Is there a reason for this class? Both it and the parent class are empty. Wouldn't one be enough?
payments/views.py
Outdated
| # if this was not created from an update operation, do nothing | ||
| if not validated.created_from_update: | ||
| return super().dispatch_success(validated) | ||
| def dispatch_success(self, validated: Any) -> HttpResponse: |
There was a problem hiding this comment.
If you're passing validated to the redirect response, shouldn't the type be str or something?
|
@tkw1536 There are two realities - one in which Selenium tests are hard to fix and one in which I am not good at writing Selenium tests. Help |
|
It looks like it's trying to test the old stripe integration and failing those tests. Possibly because you've some part of it. |
