Try Microsoft testing platform integration #6

Bertk · 2025-06-04T06:50:43Z

No description provided.

.github/workflows/dotnet.yml

github-actions · 2025-06-05T10:04:28Z

Unit Tests macos-latest

8 files 8 suites 2m 8s ⏱️
321 tests 315 ✅ 6 💤 0 ❌
324 runs 318 ✅ 6 💤 0 ❌

Results for commit 32bd4eb.

♻️ This comment has been updated with latest results.

github-actions · 2025-06-05T10:05:20Z

Unit Tests ubuntu-latest

8 files 8 suites 4m 53s ⏱️
321 tests 315 ✅ 6 💤 0 ❌
324 runs 318 ✅ 6 💤 0 ❌

Results for commit 32bd4eb.

♻️ This comment has been updated with latest results.

github-actions · 2025-06-05T10:05:59Z

Unit Tests windows-latest

8 files 8 suites 5m 34s ⏱️
321 tests 321 ✅ 0 💤 0 ❌
324 runs 324 ✅ 0 💤 0 ❌

Results for commit a2f3c97.

♻️ This comment has been updated with latest results.

Copilot

Pull Request Overview

Integrate the Microsoft Testing Platform into Coverlet by adding extension hooks, environment variable and command-line providers, and a test host process lifetime handler for coverage collection. Update CI/CD configurations and documentation to support .NET 8/9.

Introduce coverlet.MTP project with builder hook and logger adapter
Implement environment variable and command-line providers plus a process lifetime handler
Update global SDK version, CI pipelines, and documentation

Reviewed Changes

Copilot reviewed 63 out of 63 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/coverlet.MTP/TestingPlatformBuilderHook.cs	Add static hook to register Coverlet extension in test builder
src/coverlet.MTP/CoverletExtensionProvider.cs	Register environment, process handler, and CLI providers
src/coverlet.MTP/Logging/CoverletLoggerAdapter.cs	Adapter for Microsoft Testing Platform logger
src/coverlet.MTP/CoverletExtensionEnvironmentVariableProvider.cs	Stub environment variable provider
src/coverlet.MTP/CoverletExtensionConfiguration.cs	Configuration model and helper class for CLI options
src/coverlet.MTP/CoverletExtensionCommandLineProvider.cs	Define and validate command-line options
src/coverlet.MTP/CoverletExtensionCollector.cs	Implement coverage instrumentation before/after test run
global.json	Bump SDK version to 9.0.300
eng/*.yml	Update build and publish pipelines to .NET 8/9 and log patterns
Directory.*.props	Update package versions and introduce new TFMs
.github/workflows/dotnet.yml	Add GitHub Actions workflow for .NET 8/9
README.md and Documentation/*.md	Update docs for .NET 8/9 support and new settings

Comments suppressed due to low confidence (7)

src/coverlet.MTP/Collector/CoverletExtensionCollector.cs:113

Checking for null on 'OutputDirectory' doesn't catch empty strings; if it's empty, 'Path.GetDirectoryName' returns null and causes a crash. Use 'string.IsNullOrEmpty' or a default fallback.

string dOutput = _configuration.OutputDirectory != null ? _configuration.OutputDirectory : Directory.GetCurrentDirectory() + Path.DirectorySeparatorChar.ToString();

src/coverlet.MTP/TestingPlatformBuilderHook.cs:15

[nitpick] The parameter name '_' is ambiguous and reduces readability; consider renaming it to something descriptive like 'args' or 'commandLineArgs'.

public static void AddExtensions(ITestApplicationBuilder testApplicationBuilder, string[] _)

src/coverlet.MTP/CoverletExtensionConfiguration.cs:20

[nitpick] Property 'sourceMappingFile' does not follow PascalCase convention; rename to 'SourceMappingFile' for consistency with other properties.

public string sourceMappingFile { get; set; } = string.Empty;

src/coverlet.MTP/CoverletExtensionConfiguration.cs:22

[nitpick] Property 'formats' should be PascalCase (e.g., 'Formats') to match .NET naming conventions.

public string[] formats { get; set; } = ["json"];

eng/build.yml:30

[nitpick] Mixed forward and backward slashes in the project path can be confusing; use one consistent style (preferably forward slashes in YAML).

dotnet test test/coverlet.msbuild.tasks.tests\coverlet.msbuild.tasks.tests.csproj -c $(BuildConfiguration) --no-build -bl:test.msbuild.tasks.binlog ...

eng/publish-coverlet-result-files.yml:42

Switching from '**/.binlog' to '.binlog' will miss binlog files in subdirectories. Revert to the recursive pattern or adjust as needed.

Contents: '*.binlog'

.github/workflows/dotnet.yml:34

Installing .NET 9.0 then immediately installing .NET 8.0 overrides the first setup. If multi-version validation is intended, run tests in separate jobs or remove one install step.

- name: Setup .NET 9.0
-      uses: actions/setup-dotnet@v4
-      with:
-        dotnet-version: 9.0.x
+    - name: Setup .NET 8.0

Copilot · 2025-06-05T15:17:42Z

src/coverlet.MTP/CoverletExtensionProvider.cs

+      CoverletExtensionConfiguration coverletExtensionConfiguration = new();
+      if (ignoreIfNotSupported)
+      {
+#if !NETCOREAPP
+              coverletExtensionConfiguration.Enable =false;
+#endif
+      }
+


The 'ignoreIfNotSupported' flag sets 'Enable' on the configuration but the configuration is never used; either apply the flag to skip registration or remove the unused parameter.

Suggested change

CoverletExtensionConfiguration coverletExtensionConfiguration = new();

if (ignoreIfNotSupported)

{

#if !NETCOREAPP

coverletExtensionConfiguration.Enable =false;

#endif

}

Copilot · 2025-06-05T15:17:42Z

src/coverlet.MTP/CoverletExtensionEnvironmentVariableProvider.cs

+#pragma warning disable CS9113 // Parameter is unread.
+internal sealed class CoverletExtensionEnvironmentVariableProvider(IConfiguration configuration, Platform.CommandLine.ICommandLineOptions commandLineOptions, ILoggerFactory loggerFactory) : ITestHostEnvironmentVariableProvider
+#pragma warning restore CS9113 // Parameter is unread.


Several constructor parameters are unused and suppressed via pragmas; remove unused parameters or implement the environment-variable logic for clarity.

Suggested change

#pragma warning disable CS9113 // Parameter is unread.

internal sealed class CoverletExtensionEnvironmentVariableProvider(IConfiguration configuration, Platform.CommandLine.ICommandLineOptions commandLineOptions, ILoggerFactory loggerFactory) : ITestHostEnvironmentVariableProvider

#pragma warning restore CS9113 // Parameter is unread.

internal sealed class CoverletExtensionEnvironmentVariableProvider : ITestHostEnvironmentVariableProvider

Copilot · 2025-06-05T15:17:43Z

src/coverlet.MTP/CoverletExtensionConfiguration.cs

+    public void InitializeFromCommandLineArgs()
+    {
+      IServiceCollection serviceCollection = new ServiceCollection();
+      ServiceProvider serviceProvider = serviceCollection.BuildServiceProvider();


The locally built 'serviceProvider' is never used; the method then uses '_serviceProvider' instead. Either use or remove the local provider.

Suggested change

ServiceProvider serviceProvider = serviceCollection.BuildServiceProvider();

// Removed unused local variable 'serviceProvider'.

Copilot · 2025-06-05T15:17:43Z

global.json

@@ -1,5 +1,5 @@
 {
    "sdk": {
-        "version": "8.0.407"
+        "version": "9.0.300"


The global.json SDK version (9.0.300) doesn’t match the SDK used in build YAML (8.0.408); align these versions to avoid confusion.

Suggested change

"version": "9.0.300"

"version": "8.0.408"

github-actions · 2025-06-11T07:11:00Z

Summary


Generated on:	6/11/2025 - 7:10:58 AM
Coverage date:	6/11/2025 - 7:10:09 AM
Parser:	Cobertura
Assemblies:	1
Classes:	1
Files:	1
Line coverage:	100% (3 of 3)
Covered lines:	3
Uncovered lines:	0
Coverable lines:	3
Total lines:	11
Covered branches:	0
Total branches:	0
Method coverage:	Feature is only available for sponsors
Tag:	39_15578287897

Coverage

coverletsample.integration.determisticbuild - 100%

Name	Line	Branch
coverletsample.integration.determisticbuild	100%	****
Coverlet.Integration.DeterministicBuild.DeepThought	100%

initial commit

e65a593

github-advanced-security bot found potential problems Jun 4, 2025

View reviewed changes

.github/workflows/dotnet.yml Fixed Show fixed Hide fixed

update files

bc502f9

Bertk force-pushed the coverlet-MTP branch from 33c3dcd to bc502f9 Compare June 4, 2025 09:47

Bertk added 14 commits June 4, 2025 11:53

add build job dependency for tests

dd34325

upload artifacts for testing

59f3f49

fix path for test projects

c8a81e4

update dotnet.yml

1e034bd

build and test (job test)

9133300

update dotnet.yml

6d16331

use only single build phase

4782086

fix build problems

56eb04a

use '--no-build' for tests

81b00c5

add action dotnet-test-reporter

9f8f4e9

add write permission for checks

3b25ded

modify upload test results (always)

820855f

add check_name parameter

fc8b817

update reports path

dcb7ed4

Bertk self-assigned this Jun 4, 2025

Bertk added 8 commits June 4, 2025 16:27

add dotnet-test-reporter options

425e569

use publish-unit-test-result-action

ab5c0a1

Update coverlet.integration.determisticbuild.csproj

b9955af

update pipeline

4cb9917

use action dotnet-test-reporter

84006b2

use single targetframework for DeterministicTest

af7f76f

update deterministic tests

681dd13

remove bibipkins/[email protected] action

f446f23

Bertk added 4 commits June 5, 2025 12:09

fix test result upload

32bd4eb

update action

ae8fb5a

Update dotnet.yml

8f19078

update dotnet.yml

bf804e8

Bertk requested a review from Copilot June 5, 2025 15:15

Copilot AI reviewed Jun 5, 2025

View reviewed changes

Repository owner deleted a comment from github-actions bot Jun 6, 2025

Bertk added 8 commits June 6, 2025 08:31

update parameters

a927424

add buildMultiTargeting for project

44017f6

add Coverlet.MTP.unit.tests

e906f2a

update CommandLine unit test

d439379

fix conditions

59da244

add vaöidation test skeleton

625722c

Update coverlet.MTP.validation.tests.csproj

a2f3c97

update config files

b8c4005

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Try Microsoft testing platform integration #6

Try Microsoft testing platform integration #6

Uh oh!

Bertk commented Jun 4, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 5, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 5, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 5, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jun 5, 2025

Uh oh!

Copilot AI Jun 5, 2025

Uh oh!

Copilot AI Jun 5, 2025

Uh oh!

Copilot AI Jun 5, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

Uh oh!

	ServiceProvider serviceProvider = serviceCollection.BuildServiceProvider();
	// Removed unused local variable 'serviceProvider'.

Try Microsoft testing platform integration #6

Are you sure you want to change the base?

Try Microsoft testing platform integration #6

Uh oh!

Conversation

Bertk commented Jun 4, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests macos-latest

Uh oh!

github-actions bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests ubuntu-latest

Uh oh!

github-actions bot commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests windows-latest

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 11, 2025

Summary

Coverage

Uh oh!

Uh oh!

github-actions bot commented Jun 5, 2025 •

edited

Loading

github-actions bot commented Jun 5, 2025 •

edited

Loading

github-actions bot commented Jun 5, 2025 •

edited

Loading