Simplify assert subroutine and support LFortran #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit 1. Removes the diagnostic_data argument from the assert subroutine 2. Removes the types that existed solely to support that argument: a. characterizable_t b. intrinsic_array_t 3. Edits or deletes examples that referenced the removed entities 4. Edits or deletes documentation that referenced removed entities
bonachea
changed the title
|
@rouson Thanks for this PR. I would like the opportunity to review this PR in detail before merge, but given several impending deadlines I might not have time until next week. Is there a particular deadline for this change? On a related note, I agree that a breaking change probably motivates a new major version once the changes are eventually packaged into a release. However this PR is not actually creating that release, so I've renamed the PR accordingly. I've been separately working on some orthogonal changes I'd also like to see in the next Assert release, hopefully those will reach PR later this month. |
Also manually inline string function.
Fix test
rouson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation of this PR is simplifying the
assertsubroutine by removing the optionaldiagnostic_dataargument, the utility of which is largely displaced by Julienne's new assertion feature, which automatically generates and embeds diagnostic information in thedescriptionargument when calling Assert's.Towards this end, this PR removes
assertsubroutine'sdiagnostic_dataargument,a.
characterizable_tb.
intrinsic_array_t,exampledirectory, anddocdirectoryA secondary motivation for this PR is supporting the LFortran compiler, which has strategic importance related to upcoming work. The README.md in the root directory has been reorganized and updated to include instructions for building and testing with
lfortran.All tests in this PR pass when run in a single image locally with
flang-new,gfortran,ifx,lfortran, andnagfor.Because this PR introduces a breaking change, semantic versioning suggests it be released as version 3.0.0.