Resolved FileNotFoundErrors encountered in pymapconv.py #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DriesDD
commented
Mar 6, 2024
DriesDD
commented
- minimapthread subprocess.Popen now uses the shell to resolve FileNotFoundError
- ensure that Temp directories are created to prevent errors like FileNotFoundError: [Errno 2] No such file or directory: 'temp\thread2\temp6.BMP'
- Fixed another FileNotFoundError related to nvdxt.exe by rewriting the path code
Resolved FileNotFoundErrors encountered at runtime on Windows. - minimapthread subprocess.Popen now uses the shell to resolve FileNotFoundError - ensure that Temp directories are created to prevent errors like FileNotFoundError: [Errno 2] No such file or directory: 'temp\\thread2\\temp6.BMP' - Fixed another FileNotFoundError related to nvdxt.exe by rewriting the path code
|
This is my fix to use the script by fixing errors in the order I encountered them. Also, there is one final error from line 966 with minimap.dds not being found that I could resolve by changing the code to look for minimap.bmp which is generated correctly, and while the script now runs to completion it still doesn't generate a working minimap so I don't want to commit that. I guess the .dds extension is not a mistake but the file is not created properly. |
|
The minimap dds binary blob gets embedded into the .smf output file, and is thus required for successful compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.