Added a ros topic logger #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello ,
I have created a ros topic logger based on the msg definitions that are on this repository.
I added a name field to the StatusChange.msg file , and also removed the tree definition from the StatusChangeLog.msg ,
since it seems to me that when publishing changes , sending the whole tree which already contains every state is wasteful.
This makes the topic publisher work similarly to the nav2 implementation.
This was tested together with pull request #21 and then rebased , however there is no reason it wouldn't work by itself.
Thanks!