Make sequence node inheritable #996
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: redvinaa <[email protected]>
Signed-off-by: redvinaa <[email protected]>
Signed-off-by: redvinaa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR following up on #991. Turns out more changes were needed to allow other nodes inherit from
SequenceNode.The derived class has to call the
tickmethod of the base class. If instead I callexecuteTick, the overwrittentickfunction is called, resulting in infinite recursion.Also, the node configuration has to be passed to the
ControlNode, otherwise the blackboard can't see the variables set for the node. I don't know why this is, if this is not the way, some would be appreciated on how to do this properly.Needed for ros-navigation/navigation2#5247