Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for column transformers #189

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

carlos-granados
Copy link
Contributor

  • The "Definitions" page was too long. I have extracted the information about transformations into another page
  • Added documentation for some transformers that were not documented like the row: transformer and the rowtable: transformer
  • Added documentation for the new "column:" transformer

Copy link
Contributor

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just one small typo / paste error in the example. Thanks for splitting this out to a separate page, much easier to find and reference!

Comment on lines 180 to 181
$user->setUsername($userHash['name']);
$user->setFollowersCount($userHash['followers']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$user->setUsername($userHash['name']);
$user->setFollowersCount($userHash['followers']);
$user->setUsername($row['name']);
$user->setFollowersCount($row['followers']);

@carlos-granados carlos-granados merged commit e76df69 into Behat:v3.0 Feb 14, 2025
4 checks passed
@carlos-granados carlos-granados deleted the column-transformer branch February 14, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants