Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Config - Context #182

Merged
merged 2 commits into from
Feb 14, 2025
Merged

PHP Config - Context #182

merged 2 commits into from
Feb 14, 2025

Conversation

loic425
Copy link
Contributor

@loic425 loic425 commented Dec 9, 2024 •
edited
Loading

@loic425 loic425 marked this pull request as draft December 9, 2024 08:29
@loic425 loic425 force-pushed the php-config/context branch from b3051d3 to 7224c2b Compare December 9, 2024 08:33
@loic425 loic425 marked this pull request as ready for review December 23, 2024 07:35
@loic425 loic425 mentioned this pull request Dec 23, 2024
Open
acoulton
acoulton requested changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @loic425, just got a few changes to suggest (mostly all the same thing).

Joyeux Noël!

@carlos-granados
Copy link
Contributor

@loic425 do you think you might be able to work on the changes suggested by @acoulton? If that is not the case, please let us know and I will add them myself, we really want to get the documentation fully changed to use the new PHP config format

And thanks for all your work around this!!

@loic425
Copy link
Contributor Author

loic425 commented Feb 13, 2025

@carlos-granados Yes, sorry I was busy this january, a lot of work with Sylius stack documentation and a customer project.
I think I could finish this one tomorrow morning. But I'm not yet sure to adapt the whole documentation, but we'll see.
I'm very happy with the implementation we did together, and I hope to have time to implement the glob feature to import configuration files.

@loic425
Copy link
Contributor Author

loic425 commented Feb 13, 2025

I've applied all the suggestion tell me if I need to squash the two commits.

acoulton
acoulton approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @loic425 that looks good - no need to worry about squashing we can just squash merge.

carlos-granados
carlos-granados reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@carlos-granados carlos-granados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks @loic425

@carlos-granados carlos-granados merged commit d9a6800 into Behat:v3.0 Feb 14, 2025
4 checks passed
@loic425 loic425 deleted the php-config/context branch February 14, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-granados carlos-granados carlos-granados left review comments

@acoulton acoulton acoulton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loic425 @carlos-granados @acoulton