Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amqp): make amqp v2 compatible #63

Merged

Conversation

thibaudgirard
Copy link
Contributor

@thibaudgirard thibaudgirard commented Feb 28, 2024

Some methods signatures have been changed since the new version of amqp (see here: https://github.com/php-amqp/php-amqp/blob/latest/UPGRADING.md#amqpqueue-breaking-changes)

Here is the list of methods that needs to be updated:

AmqpBundle/Amqp/Consumer::class

- public function ackMessage(string $deliveryTag, int $flags = AMQP_NOPARAM): bool
+ public function ackMessage(int $deliveryTag, int $flags = AMQP_NOPARAM): void
- public function nackMessage(string $deliveryTag, int $flags = AMQP_NOPARAM): bool
+ public function nackMessage(int $deliveryTag, int $flags = AMQP_NOPARAM): void
- public function purge(): bool
+ public function purge(): void

AmqpBundle/Event/AckEvent::class & AmqpBundle/Event/NackEvent::class

- public function getDeliveryTag(): string
+ public function getDeliveryTag(): int

@thibaudgirard thibaudgirard marked this pull request as ready for review February 28, 2024 13:23
@thibaudgirard thibaudgirard requested a review from a team as a code owner February 28, 2024 13:23
@thibaudgirard thibaudgirard force-pushed the feat/make-amqp-v2-compatible branch 11 times, most recently from 3667c3a to cfbcf8f Compare March 1, 2024 10:28
@thibaudgirard thibaudgirard self-assigned this Mar 1, 2024
@thibaudgirard thibaudgirard force-pushed the feat/make-amqp-v2-compatible branch 4 times, most recently from dda0a0a to 43887b0 Compare March 5, 2024 10:35
@thibaudgirard thibaudgirard force-pushed the feat/make-amqp-v2-compatible branch 2 times, most recently from b34171e to a9209c2 Compare March 6, 2024 08:26
@thibaudgirard thibaudgirard force-pushed the feat/make-amqp-v2-compatible branch from a9209c2 to 9b53ac6 Compare March 6, 2024 08:28
@thibaudgirard thibaudgirard merged commit 968a190 into BedrockStreaming:master Mar 12, 2024
8 checks passed
@thibaudgirard thibaudgirard deleted the feat/make-amqp-v2-compatible branch March 12, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants