-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amqp): make amqp v2 compatible #63
Merged
thibaudgirard
merged 10 commits into
BedrockStreaming:master
from
thibaudgirard:feat/make-amqp-v2-compatible
Mar 12, 2024
Merged
feat(amqp): make amqp v2 compatible #63
thibaudgirard
merged 10 commits into
BedrockStreaming:master
from
thibaudgirard:feat/make-amqp-v2-compatible
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3667c3a
to
cfbcf8f
Compare
Tom32i
approved these changes
Mar 1, 2024
dda0a0a
to
43887b0
Compare
b34171e
to
a9209c2
Compare
a9209c2
to
9b53ac6
Compare
0-Yorick-0
approved these changes
Mar 6, 2024
KillaFu69
approved these changes
Mar 11, 2024
Tom32i
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some methods signatures have been changed since the new version of amqp (see here: https://github.com/php-amqp/php-amqp/blob/latest/UPGRADING.md#amqpqueue-breaking-changes)
Here is the list of methods that needs to be updated:
AmqpBundle/Amqp/Consumer::class
AmqpBundle/Event/AckEvent::class
&AmqpBundle/Event/NackEvent::class