Improve directory watching for macOS compatibility#349
Open
aomsinister wants to merge 2 commits intoBedrock-OSS:developfrom
Open
Improve directory watching for macOS compatibility#349aomsinister wants to merge 2 commits intoBedrock-OSS:developfrom
aomsinister wants to merge 2 commits intoBedrock-OSS:developfrom
Conversation
Update 1.7.0
Refactor directory watching to add root and subdirectories for macOS compatibility.
Member
|
Unfortunately, no. See the comment below. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Fixes the
regolith watchcommand failing on macOS with the error:Problem
The watch command was using the experimental
"..."recursive watching syntax (filepath.Join(root, "...")) from the fsnotify fork, which doesn't work reliably on macOS.Solution
"..."syntax withfilepath.WalkDirto manually traverse and add each subdirectory to the watcherosimport foros.DirEntryTesting
Tested on:
Changes
regolith/watcher.go:watch()function to usefilepath.WalkDirosto imports