Conversation
…d of calling it instantly in some exceptional cases (Run and Watch).
…'TestNestedRemoteFilter' test to actually make it test what it should test.
…ortProject()`: - The function has an erly exit defined if the flat is true. - The experimental flags don't change during program's runtime. - This means that all other checks for this flag being false were unnecessary.
…ting goroutines into a single loop while preserving existing functionality.
…unning with, 'regolith run' command to match the name of the command.
Go simple eval properties
…Regolith fails to read export paths from profile, it returns an error.
…rt, it returns error instead of disabling the experiment and printing a warning.
destination that lack counterparts in the source and optimized the code: - The function now uses a linked list instead of a map to track of paths for removal. This should be more efficient because it doesn't require hashing the paths. - Removed check for duplicate paths, since it's impossible to get them when walking the files once. - Updated size_time_check_optimization testdata to generate more complex scenarios, including subdirectories.
%var% syntax. - Variables are parsed and expanded only once, this way it's impossible to create an infinite loop from variables that refer to each other. - Added tests for environment variable expansion.
when running Git commands with long output.
of '\\'. Updated the data in tests to reflect that change.
filters that use the 'exportData' feature.
…th symlink_export
Cleaning the export paths during creation of the symlinks also validates the deletion safety.
when the use_symlink_export experiment is disabled.
Optimizations
…alysis/modernize/cmd/modernize@latest -fix -test ./...'/
…ntroduced in Minecraft 1.21.120: - The world export tries to export to the user folder - The development export tires to export to the Shared folder - Added new environmnent variables COM_MOJANG_WORLDS, COM_MOJANG_PACKS, COM_MOJANG_WORLDS_PREVIEW and COM_MOJANG_PACKS_PREVIEW. Based on the context they're used to find the com.mojang path. If none of these are implemented, the old environment variables are used (COM_MOJANG or COM_MOJANG_PREVIEW). If they are also not defined Regolith tries to find the path in %APPDATA%.
com.mojang directory.
… function when the export target is a world identified by name and it doesn't exist.
Support default Minecraft 1.21.120 paths
- Changed some if-else statements to switch-case - Changed strings.Replace(..., -1) to strings.ReplaceAll - Removed unused arguments from some functions.
stirante
approved these changes
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
symlink_exportexperiment Optimizations #328${var}/$varformat in addition to previously existing%var%modeandinitialadded mode to the go-simple-eval set #331.mode- "run" or "watch" based on the mode that Regolith is running in.initial- in watch mode set to true during the first run, then it changes to false. In run mode always true.%APPDATA%/Users/Shared/games/com.mojang/...%APPDATA%/Users/<other-directory>/games/com.mojang/.... Note:<other-directory>here means the directory that is notShared. Regolith picks the first tone that it can find, which in normal case would be the user folder where Minecraft stores the worlds.COM_MOJANG_WORLDS- the location of thecom.mojangfolder used when exporting to "world" target in the "standard" Minecraft build.COM_MOJANG_PACKS- the location of thecom.mojangfolder used when exporting to "development" target in the "standard" Minecraft build.COM_MOJANG_WORLDS_PREVIEW- the location of thecom.mojangfolder used when exporting to "worlds" target in the "preview" Minecraft build.COM_MOJANG_PACKS_PREVIEW- the location of thecom.mojangfolder used when exporting to "development" target in the "preview" Minecraft build.